match next.js client side routing (buildManifest rewrites & devPagesManifest HMR) #3701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
ForsakenHarmony
changed the title
|
ijjk
reviewed
Feb 8, 2023
| @@ -13,6 +14,12 @@ const loadNextConfig = async (silent) => { | |||
|
|
|||
| nextConfig.generateBuildId = await nextConfig.generateBuildId?.(); | |||
|
|
|||
| const customRoutes = await loadCustomRoutes(nextConfig); | |||
There was a problem hiding this comment.
We should be creating this on the Next.js side so that we don't have to call loadCustomRoutes twice x-ref: https://github.com/vercel/next.js/blob/7654d7bc2d95c8b3dc18cf5e94695375c733e74c/packages/next/src/server/lib/route-resolver.ts#L28
There was a problem hiding this comment.
We load the whole config a second time to call the route resolver right now unfortunately
There was a problem hiding this comment.
@ijjk is there any chance we could get something implemented on the next.js side that would allow the whole config to be serialized to JSON (after loading custom routes probably)?
jridgewell
approved these changes
Feb 8, 2023
|
|
||
| #[derive(Clone, Debug, PartialEq, Serialize, Deserialize, TraceRawVcs)] | ||
| #[serde(rename_all = "camelCase")] | ||
| pub struct Redirect { |
There was a problem hiding this comment.
Do we need to implement all of these if we only care about Rewrite?
There was a problem hiding this comment.
Probably not 🤷♀️
But maybe we can pass the serialized version to the next.js router
ForsakenHarmony
force-pushed
the
hrmny/web-515-match-nexts-client-side-routing
branch
from
468dc29
to
e802dbc
Compare
jridgewell
approved these changes
Feb 9, 2023
ForsakenHarmony
force-pushed
the
hrmny/web-515-match-nexts-client-side-routing
branch
from
ba9e259
to
e9294f2
Compare
jridgewell
approved these changes
Feb 9, 2023
| CatchAll, | ||
| } | ||
|
|
||
| impl From<&str> for PageSortKey { |
There was a problem hiding this comment.
I think we can bound the lifetime of PageSortKey by the &str, so we don't need to clone into a String?
Suggested change
| impl From<&str> for PageSortKey { | |
| impl<'a> From<&'a str> for PageSortKey<'a> { |
There was a problem hiding this comment.
I was assuming the &str wouldn't survive after returning out of the sort_by_cached_key lambda function, but let me check
There was a problem hiding this comment.
yeah
error: lifetime may not live long enough
--> crates\next-core\src\manifest.rs:77:39
|
77 | routes.sort_by_cached_key(|s| s.split('/').map(PageSortKey::from).collect::<Vec<_>>());
| -- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ returning this value requires that `'1` must outlive `'2`
| ||
| |return type of closure is Vec<PageSortKey<'2>>
| has type `&'1 std::string::String`
ForsakenHarmony
deleted the
hrmny/web-515-match-nexts-client-side-routing
branch
Benchmark for 6eab4b9
Click to view full benchmark
|
timneutkens
pushed a commit
to vercel/next.js
that referenced
this pull request
Feb 10, 2023
…49736102+kodiakhq[bot]@users.noreply.github.com> # New Features - vercel/turbo#3540 - vercel/turbo#3549 - vercel/turbo#3465 - vercel/turbo#3550 - vercel/turbo#3495 - vercel/turbo#3624 - vercel/turbo#3600 - vercel/turbo#3676 - vercel/turbo#3689 # Fixes - vercel/turbo#3437 - vercel/turbo#3542 - vercel/turbo#3531 - vercel/turbo#3552 - vercel/turbo#3551 - vercel/turbo#3597 - vercel/turbo#3644 - vercel/turbo#3623 - vercel/turbo#3634 - vercel/turbo#3574 - vercel/turbo#3673 - vercel/turbo#3675 - vercel/turbo#3723 - vercel/turbo#3677 - vercel/turbo#3717 - vercel/turbo#3701 # Performance Improvements - vercel/turbo#3361 - vercel/turbo#3619 --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
jridgewell
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.