include omit entries in hash #3552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 10 Ignored Deployments
|
jridgewell
approved these changes
Jan 31, 2023
| @@ -977,6 +977,8 @@ impl Asset for EcmascriptChunk { | |||
| hasher.write_value(id.await?); | |||
| need_hash = true; | |||
| } | |||
| // Marker to end evaluate | |||
| hasher.write_value(true); | |||
There was a problem hiding this comment.
Should this have written a length header instead of a bool footer?
There was a problem hiding this comment.
Both evaluate and omit could write length headers (or 0 when N/A).
Benchmark for 29569da
Click to view full benchmark
|
|
Benchmark for 4f716e0
Click to view full benchmark
|
sokra
added
the
pr: automerge
Benchmark for f00ca10
Click to view full benchmark
|
mehulkar
pushed a commit
that referenced
this pull request
Feb 1, 2023
The omit entries need to be included into chunk hashing to avoid conflicting filenames when only omit entries differ
timneutkens
pushed a commit
to vercel/next.js
that referenced
this pull request
Feb 10, 2023
…49736102+kodiakhq[bot]@users.noreply.github.com> # New Features - vercel/turbo#3540 - vercel/turbo#3549 - vercel/turbo#3465 - vercel/turbo#3550 - vercel/turbo#3495 - vercel/turbo#3624 - vercel/turbo#3600 - vercel/turbo#3676 - vercel/turbo#3689 # Fixes - vercel/turbo#3437 - vercel/turbo#3542 - vercel/turbo#3531 - vercel/turbo#3552 - vercel/turbo#3551 - vercel/turbo#3597 - vercel/turbo#3644 - vercel/turbo#3623 - vercel/turbo#3634 - vercel/turbo#3574 - vercel/turbo#3673 - vercel/turbo#3675 - vercel/turbo#3723 - vercel/turbo#3677 - vercel/turbo#3717 - vercel/turbo#3701 # Performance Improvements - vercel/turbo#3361 - vercel/turbo#3619 --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The omit entries need to be included into chunk hashing to avoid conflicting filenames when only omit entries differ