feat: add vite_command crate for command execution#296
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ceedc0a to
e10f17a
Compare
bfc2e9e to
5826052
Compare
70c2e15 to
2e9276a
Compare
2e9276a to
06cf754
Compare
f409ec7 to
dbd0974
Compare
dbd0974 to
af40762
Compare
af40762 to
bc1410d
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 16 out of 18 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bc1410d to
d258eb1
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 17 out of 19 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fengmk2
commented
Nov 19, 2025
4786a76 to
8ba34bc
Compare
8ba34bc to
59f106d
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 16 out of 18 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
59f106d to
4fd6e56
Compare
branchseer
approved these changes
Nov 20, 2025
Member
Author
graphite-app bot
pushed a commit
that referenced
this pull request
Mar 26, 2026
…#1096) ## Summary - Bump vite-task to [2663222c](voidzero-dev/vite-task#296) which merges synthetic task's `input` config with parent cache config and supports `GlobWithBase` with `InputBase::Workspace` - Add `!node_modules/.vite-temp/**` negative input glob (workspace-root-relative) to Pack and Build subcommands - Update test for `trailing_var_arg` CLI parsing change - Add comprehensive snap tests for cache behavior Vite writes transient compiled config files to `node_modules/.vite-temp/` during builds. These files were tracked by fspy as both read and written, causing a read-write overlap that prevented caching ("not cached because it modified its input"). The fix passes `!node_modules/.vite-temp/**` as a `GlobWithBase { base: InputBase::Workspace }` negative glob via `EnabledCacheConfig.input` on Pack and Build subcommands. vite-task PR [#296](voidzero-dev/vite-task#296) ensures this glob is resolved relative to the workspace root and merged into the parent task's input config. vite-task changelog: voidzero-dev/vite-task@69cc6eb...2663222#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed ## Snap tests | Test | Verifies | | --- | --- | | `command-pack-monorepo` | cache hit (root + sub dir), source change miss, direct `vp pack` not cached | | `vp-build-cache` | cache hit via `vp run`, direct `vp build` not cached | | `vp-build-cache-monorepo` | cache hit (root + sub dir), source change miss, direct `vp build` not cached | | `vp-pack-cache-disabled` | `cache: false` disables caching for `vp pack` | | `vp-build-cache-disabled` | `cache: false` disables caching for `vp build` | ## Test plan - [x] `cargo check` and `cargo test` pass (with `-D warnings`) - [x] All snap tests pass locally - [x] CI passes on all platforms Closes #1095 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TL;DR
Add a new
vite_commandcrate for executing commands with file system access tracking.What changed?
vite_commandcrate that provides utilities for running commands with file system access tracking usingfspyrunCommand()function that can be imported from@voidzero-dev/vite-plus/bindingHow to test?
Run the new tests:
Try using the new API in JavaScript:
Why make this change?
This change provides a robust way to track file system accesses made by child processes, which is essential for features like dependency tracking, caching, and build optimization. By exposing this functionality through JavaScript bindings, it enables the CLI to implement more intelligent build tools that can understand exactly which files are being read or written during command execution.