forked from joomla/joomla-cms
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.0 dev - Pull request. #4
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes #26650 - Makes fields optional when creating articles in the API
Most of the options fieldsets have a css class of .options-grid-form-full which means that they should be in one column. However as can be seen below they are in **two** uneven columns ![image](https://user-images.githubusercontent.com/1296369/66870244-ebb3b000-ef98-11e9-8711-e80e634b4b48.png) The cause of this is the description div which is set to start at col 1 and end at col 3 eben though at this resolution there is only 1 column. ``` .com_config .tab-description { grid-column: 1/3; } ```
…9312) Issue occurred when Kunena had set a session variable of the form `<strong>Some text</strong>`. `json_encode` was converting this to `<strong>Some text<\/strong>` - which was then an unclosed `<strong>` tag which was disrupting the remainder of the debug output. This fix adds `JSON_UNESCAPED_SLASHES` to the json_encode, and escapes any HTML in the JSON output.
This PR removes the "feature" link from the actions dropdown in the "featured articles" view as it is never possible in this view to feature aan article
as reported by @pe7er #26620 with the code from @infograf768
Add aria hidden class to the icon and sr-only text to indicate that it is the default menu pr for #26656
Spotted these multiline options while checking a different bug. This PR puts the options into one line to be consistent with all the other options Code Review only
* fix error * revert
The labels for some of these fields was missing or not being used due to the layout. In addition the labels have been standardised to "Select Client" which is more in keeping with other similar labels. To test you will need to apply the patch and then view the source code to see that all these filters have an sr-only label of Select Client
As confirmed #25359 (comment) this line does nothing as the files have been removed
* init * Update _sidebar.scss * Update _sidebar.scss * sort rtl * fix badges * move rtl to sidebar scss
#26889) * No DB connection encryption for localhost * Reset db encryption fields if localhost Reset db encryption fields in global config server section if db host is localhost
* added trim filter * tabs * alpha order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Expected result
Actual result
Documentation Changes Required