Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0 dev - Pull request. #4

Merged
merged 5,093 commits into from Dec 4, 2019
Merged

4.0 dev - Pull request. #4

merged 5,093 commits into from Dec 4, 2019

Conversation

vuchkov
Copy link
Owner

@vuchkov vuchkov commented Dec 4, 2019

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required

dgrammatiko and others added 30 commits October 19, 2019 16:40
- Fixes #26650
- Makes fields optional when creating articles in the API
Most of the options fieldsets have a css class of .options-grid-form-full which means that they should be in one column.

However as can be seen below they are in **two** uneven columns
![image](https://user-images.githubusercontent.com/1296369/66870244-ebb3b000-ef98-11e9-8711-e80e634b4b48.png)

The cause of this is the description div which is set to start at col 1 and end at col 3 eben though at this resolution there is only 1 column.

```
.com_config .tab-description {
    grid-column: 1/3;
}
```
…#24897)

The Joomla 4 re-do version of this: #14671

This adds the ability to display images and introtext fields for articles in contact pages.

Despite not being used in the default core view, this is useful to make the introtext and images fields available at your disposal to use in overrides.
…9312)

Issue occurred when Kunena had set a session variable of the form `<strong>Some text</strong>`.

`json_encode` was converting this to  `<strong>Some text<\/strong>` - which was then an unclosed `<strong>` tag which was disrupting the remainder of the debug output.

This fix adds `JSON_UNESCAPED_SLASHES` to the json_encode, and escapes any HTML in the JSON output.
This PR removes the "feature" link from the actions dropdown in the "featured articles" view as it is never possible in this view to feature aan article
Add aria hidden class to the icon and sr-only text to indicate that it is the default menu

pr for #26656
Spotted these multiline options while checking a different bug.

This PR puts the options into one line to be consistent with all the other options

Code Review only
ciar4n and others added 29 commits November 25, 2019 11:41
The labels for some of these fields was missing or not being used due to the layout. In addition the labels have been standardised to "Select Client" which is more in keeping with other similar labels.

To test you will need to apply the patch and then view the source code to see that all these filters have an sr-only label of Select Client
As confirmed #25359 (comment) this line does nothing as the files have been removed
* init

* Update _sidebar.scss

* Update _sidebar.scss

* sort rtl

* fix badges

* move rtl to sidebar scss
#26889)

* No DB connection encryption for localhost

* Reset db encryption fields if localhost

Reset db encryption fields in global config server section if db host is localhost
* added trim filter

* tabs

* alpha order
@vuchkov vuchkov merged commit 54d8dc2 into vuchkov:4.0-dev Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet