Makefile: Login to docker hub before setting up integration tests - #4657
Merged
Conversation
zebot
added
the
ok-to-test
Only logs in if the credentials are provided.
akshaymankar
force-pushed
the
docker-hub-login
branch
from
July 10, 2025 13:05
2eb7a5f to
e32c2a9
Compare
supersven
reviewed
Jul 10, 2025
supersven
reviewed
Jul 10, 2025
|
|
||
| set -euo pipefail | ||
|
|
||
| if [[ -z "${DOCKER_HUB_USERNAME+x}" ]]; then |
Contributor
There was a problem hiding this comment.
I'm wondering if there's a benefit in expanding $DOCKER_HUB_USERNAME to x 🤔
However, it doesn't hurt.
Member
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only logs in if the credentials are provided.
https://wearezeta.atlassian.net/browse/WPB-18677
Checklist
changelog.dNo changelog.