Skip to content

Makefile: Login to docker hub before setting up integration tests #4657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akshaymankar merged 1 commit into from
Jul 10, 2025
Merged

Makefile: Login to docker hub before setting up integration tests #4657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@ libzauth:
kube-integration: kube-integration-setup kube-integration-test

.PHONY: kube-integration-setup
kube-integration-setup: charts-integration
kube-integration-setup: charts-integration helm-oci-login
export NAMESPACE=$(NAMESPACE); export HELM_PARALLELISM=$(HELM_PARALLELISM); ./hack/bin/integration-setup-federation.sh

.PHONY: kube-integration-test
Expand All @@ -468,6 +468,9 @@ kube-restart-%:
kubectl delete pod -n $(NAMESPACE) -l app=$(*)
kubectl delete pod -n $(NAMESPACE)-fed2 -l app=$(*)

helm-oci-login:
./hack/bin/helm-oci-login.sh

.PHONY: latest-tag
latest-tag:
./hack/bin/find-latest-docker-tag.sh
Expand Down
9 changes: 9 additions & 0 deletions hack/bin/helm-oci-login.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
#!/usr/bin/env bash

set -euo pipefail

if [[ -z "${DOCKER_HUB_USERNAME+x}" ]]; then

@supersven supersven Jul 10, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if there's a benefit in expanding $DOCKER_HUB_USERNAME to x 🤔

However, it doesn't hurt.

@akshaymankar akshaymankar Jul 10, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For bash reasons: https://stackoverflow.com/questions/3601515/how-to-check-if-a-variable-is-set-in-bash

echo "Not logging in to docker hub as there are no credentials provided."
else
helm registry login registry-1.docker.io --username "${DOCKER_HUB_USERNAME}" --password "${DOCKER_HUB_PASSWORD}"
Comment thread
supersven marked this conversation as resolved.
fi