Skip to content

Conversation

@jleandroperez
Copy link
Contributor

Details:

This PR fine tunes the Skeleton UI's behavior.

cc @bummytime Thanks in advance!!
Closes #434

Testing:

  1. Log into your WordPress.com account
  2. Verify that the Skeleton UI shows up as soon as the Dashboard gets onscreen
  3. Wait until (some data) loads)
  4. Switch between tabs
  5. Verify that the Skeleton UI doesn't show anymore
  • Note: Whenever the current period has no cached data, the Skeleton is expected to show up.

@jleandroperez jleandroperez added the type: enhancement A request for an enhancement. label Nov 29, 2018
@jleandroperez jleandroperez added this to the 0.12 milestone Nov 29, 2018
@jleandroperez jleandroperez self-assigned this Nov 29, 2018
Copy link
Contributor

@bummytime bummytime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works beautifully, code is square too! :shipit: !

@jleandroperez jleandroperez merged commit 797b6e6 into develop Nov 29, 2018
@jleandroperez jleandroperez deleted the issue/434-updating-dashboard-ghosts-behavior branch November 29, 2018 20:13
@bummytime bummytime mentioned this pull request Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement A request for an enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants