fix(crypto): disable multisig#2057
Merged
faustbrian merged 4 commits intoArkEcosystem:developfrom Feb 4, 2019
spkjp:disable-multisig
Merged
fix(crypto): disable multisig#2057faustbrian merged 4 commits intoArkEcosystem:developfrom spkjp:disable-multisig
faustbrian merged 4 commits intoArkEcosystem:developfrom
spkjp:disable-multisig
Conversation
first batch: type 4 second batch: multi signed transactions
|
@faustbrian @air1one - please review this in the next few days. Be sure to explicitly select labels so I know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
Codecov Report
@@ Coverage Diff @@
## develop #2057 +/- ##
===========================================
- Coverage 73.81% 73.76% -0.05%
===========================================
Files 367 367
Lines 8259 8257 -2
Branches 1177 1176 -1
===========================================
- Hits 6096 6091 -5
- Misses 2131 2134 +3
Partials 32 32
Continue to review full report at Codecov.
|
faustbrian
approved these changes
Feb 4, 2019
vasild
added a commit
that referenced
this pull request
Feb 4, 2019
…peer-state * ArkEcosystem/core/develop: chore: few upgrade script fixes (#2060) misc: add github templates for docs, security and support (#2059) fix: remove entries with double and single quotes during the upgrade fix: syntax error in upgrade script fix(crypto): disable multisig (#2057) chore: add bash fallback for ARK > CORE in upgrade script refactor: move genesisBlock to network config and remove extraneous config (#2052) chore: store development docker files in docker/development (#2053)
|
Why? The ACF has plans to use multisig and there's no clear timeline for the addition of the new implemention. This would severely impede plans to remove dedicated escrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
To be superseded by AIP18.
Types of changes
Checklist