Add test and fix for trimmed_range_in_parent when the item is trimmed out - #401
Merged
jminor merged 1 commit intoDec 14, 2018
Conversation
Codecov Report
@@ Coverage Diff @@
## master #401 +/- ##
=======================================
Coverage 87.07% 87.07%
=======================================
Files 63 63
Lines 5580 5580
=======================================
Hits 4859 4859
Misses 721 721
Continue to review full report at Codecov.
|
jminor
approved these changes
Dec 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug in
trimmed_range_in_parentthat was causing a crash when the item was trimmed out of the parent. Now it correctly returnsNoneand has a unit test for this.