perf(crypto): make address network byte check part of serde

[spkjp]

Summary

The ajv address schema calls Base58.decodeCheck to validate the network byte. But during transaction serialization, the address is also decoded, so we end up doing it again. By performing the network byte validation during transaction serialization we can get rid of the decode call during schema validation. This makes multipayment processing approx. 25% faster.

Checklist

• Documentation (if necessary)
• Tests (if necessary)
• Ready to be merged

[lgtm-com]

This pull request introduces 1 alert when merging b90dc92 into 575234e - view on LGTM.com

new alerts:

• 1 for Unused variable, import, function or class

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (develop@575234e). Click here to learn what that means.
The diff coverage is 76.47%.

@@            Coverage Diff             @@
##             develop    #3000   +/-   ##
==========================================
  Coverage           ?   29.79%           
==========================================
  Files              ?      424           
  Lines              ?    10168           
  Branches           ?      538           
==========================================
  Hits               ?     3030           
  Misses             ?     7093           
  Partials           ?       45

Impacted Files	Coverage Δ
...atchers/src/transactions/valid-second-signature.ts	0% <ø> (ø)
packages/crypto/src/validation/schemas.ts	100% <ø> (ø)
packages/crypto/src/transactions/types/transfer.ts	100% <100%> (ø)
...ges/crypto/src/transactions/types/multi-payment.ts	50% <100%> (ø)
packages/crypto/src/transactions/serializer.ts	54.31% <100%> (ø)
packages/crypto/src/validation/keywords.ts	57.14% <100%> (ø)
...ackages/crypto/src/transactions/types/htlc-lock.ts	42.42% <33.33%> (ø)
packages/crypto/src/errors.ts	47.16% <50%> (ø)
packages/crypto/src/identities/address.ts	66.66% <85.71%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 575234e...47af879. Read the comment docs.

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (develop@575234e). Click here to learn what that means.
The diff coverage is 88.23%.

@@            Coverage Diff             @@
##             develop    #3000   +/-   ##
==========================================
  Coverage           ?   65.83%           
==========================================
  Files              ?      424           
  Lines              ?    10168           
  Branches           ?      538           
==========================================
  Hits               ?     6694           
  Misses             ?     3429           
  Partials           ?       45

Impacted Files	Coverage Δ
...atchers/src/transactions/valid-second-signature.ts	100% <ø> (ø)
packages/crypto/src/validation/schemas.ts	100% <ø> (ø)
packages/crypto/src/transactions/types/transfer.ts	100% <100%> (ø)
...ges/crypto/src/transactions/types/multi-payment.ts	100% <100%> (ø)
packages/crypto/src/transactions/serializer.ts	87.93% <100%> (ø)
packages/crypto/src/validation/keywords.ts	87.5% <100%> (ø)
...ackages/crypto/src/transactions/types/htlc-lock.ts	100% <100%> (ø)
packages/crypto/src/errors.ts	79.24% <50%> (ø)
packages/crypto/src/identities/address.ts	95.83% <85.71%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 575234e...47af879. Read the comment docs.