Add waitForAllTaskTermination#21
Add waitForAllTaskTermination#21norio-nomura wants to merge 1 commit intoCarthage:upgrade-racfrom norio-nomura:wait-for-all-task-termination
Conversation
Fix segmentation fault on Carthage termination. Carthage/Carthage#474 (comment)
There was a problem hiding this comment.
I think this should be created within launchTask, since TaskDescriptions can be reused across multiple task invocations.
|
Thanks for the pull request! ✨ I think I've misunderstood the purpose, so my comments above may not be valuable. If we need to wait for all tasks to complete before exiting on the main thread, I'd prefer to incorporate that into our |
|
I did want to prove what happened and how can be fixed. 😄 |
|
Ah, okay. I'm happy to give it a shot! Thank you so much for finding the issue. 🙇⭐ |
|
I hope that all reported segmentation fault on termination are on this scenario and will be fixed. 🙏 |
|
Should be fixed by #23. 🎉 Thanks again for finding that! |
|
I'm sorry I couldn't write proper code for fix this by my self. |
|
@norio-nomura No apologies necessary, you contributed a great deal by diagnosing the issue 🙇 |
|
@robrix Thanks 😃 |
Fix segmentation fault on Carthage termination.
Carthage/Carthage#474 (comment)