Add waitForAllTaskTermination for fixing segmentation fault of Carthage#24
Add waitForAllTaskTermination for fixing segmentation fault of Carthage#24robrix merged 1 commit intoCarthage:masterfrom norio-nomura:wait-for-all-task-termination
Conversation
Fix segmentation fault on Carthage termination. Carthage/Carthage#474 (comment)
|
It looks like @jspahrsummers left some feedback on #21. Could you that feedback on this PR please? |
|
Thanks for reviewing. |
|
Okay, thanks for the info. I think given the practical considerations that we ought to merge this PR, and then if it needs adjustment we can do that later on. Thanks very much for the PR and your investigation into the segfaults, @norio-nomura! |
Add waitForAllTaskTermination for fixing segmentation fault of Carthage
|
Thank you for reviewing & merging it. I have one more ReactiveCocoa/ReactiveCocoa#2058 related to Carthage hangs. I wish it will be also merged to next release. |
|
Cool, merged. |
|
Thanks! |
|
Oh, I should said about ReactiveCocoa before I pushed update |
|
Don’t sweat it! |
|
Thanks, |
This is rebased version of #21.
Fix segmentation fault on termination of Carthage.
Segmentation fault on termination of Carthage 0.7.4 beta-2 happens following scenario:
sendCompleted()and kick main thread2a. main thread wake up and call
exit()2b. launchTask's thread continue disposing
Waiting
completedfrom launchTask's thread is not enough for fixing the segmentation fault.It needs waiting actual termination of launchTask's thread
Carthage/Carthage#474 (comment)