Replace incremental data sinks with a single stream of TaskEvent enums#23
Merged
jspahrsummers merged 7 commits intomasterfrom Jun 1, 2015
Merged
Conversation
jspahrsummers
changed the title
This was referenced May 28, 2015
|
#22 has been merged. |
Member
Author
|
🙌 |
Contributor
There was a problem hiding this comment.
When terminationStatus != EXIT_SUCCESS, signal from stderrProducer does not wait signal from stdoutProducer. Signal from other hand does not be needed, but should be waited.
I guess this cause segmentation fault of Carthage/Carthage#497
changed comment position
Member
Author
|
@norio-nomura Good catch yet again! I've pushed a fix for that issue. |
Contributor
Member
Author
|
There are still issues here, but I think it's in our interest to make a less broken Carthage release available. I'd like to merge this, and continue to investigate the remaining issues separately. Also, any help on that front would be greatly appreciated. 🙏 |
jspahrsummers
added a commit
that referenced
this pull request
Jun 1, 2015
…e-results Replace incremental data sinks with a single stream of TaskEvent enums
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #22.This is a refactoring that should've been done when we first moved from
ColdSignal+HotSignaltoSignalProducer+Signal.The current sink-focused implementation bifurcates logic, and makes it really easy to introduce issues like that fixed by #21. Handling everything within the same stream should make behavior more deterministic.