Migrate mission UI to imGUI

[RenechCDDA]

Summary

Interface "Mission UI migrated to imGUI"

Purpose of change

Continuing the move to imGUI.

Describe the solution

Migrate it.

Describe alternatives you've considered

N/A

Testing

(Still very WIP)

2024-04-19.14-48-10.mp4

Additional context

[RenechCDDA]

I've gotten most of the kinks worked out at this point, but I still need to add deadline information and "likely rewards". I've never actually seen them displayed on the old window, but we have code support for it, so the imGUI version will too.

After that it's just a matter of plugging in the correct function calls to make the windows resize to fit terminal size.

[RenechCDDA]

Now I am pretty sure the only thing left to do is figure out how to handle window sizing and then ship it.

[db48x]

Good to see adoption :)

[RenechCDDA]

I realized that I dropped the ability to set a mission as 'active' (target OMT shows up on the overmap, if you have a target) so that needs to be resolved. Marking as draft until then...

[RenechCDDA]

I changed the UI-shown language around the player's "active mission" to "(current) objective" because there is both the "active mission" and your "active missions", and that is... terribly unnecessary.
If anyone has some opinion on this, this PR is your chance to raise it!

[RenechCDDA]

I'm proud to say that this is fully mouse-compatible, and you can switch between mouse and keyboard as desired. Setting your current objective ("active mission" as it used to be known) with the mouse is accomplished by double clicking. As far as I can tell this is neither remappable nor shown in the keybindings menu, but it exists. The normal keyboard input to do so is "CONFIRM" (enter/return), same as before.

And yes the current objective is no longer highlighted green, but instead displayed at the top of the missions window. I expect to receive angry letters over this.

[db48x]

I just ran it and got an assertion from ImGui:

cataclysm-tiles: src/third-party/imgui/imgui_tables.cpp:1464: void ImGui::TableSetupColumn(const char*, ImGuiTableColumnFlags, float, ImGuiID): Assertion `init_width_or_weight <= 0.0f && "Can only specify width/weight if sizing policy is set explicitly in either Table or Column."' failed.

This is when calling TableSetupColumn for the Description column. It’s also on a fresh game with no missions, if that matters.

[db48x]

I changed that column to ImGuiTableColumnFlags_WidthFixed and it works fine. Overall the UI works really well, but it is odd that the mission list is not as tall as the whole window. I guess that’s not technically important, but personally I’d fix it before committing.

[RenechCDDA]

but it is odd that the mission list is not as tall as the whole window.

This is actually a regression, currently the window size is being set by its contents (the size of the table) and the size of the table is extending downwards outside of the actually visible listbox.

(Not pushed) Calls to ImGui::SetNextWindowSizeConstraints() are not being heeded. I was going to overcome this by allowing the window to be resizable but even if I exclude the bit flag it's always set upstream, and I don't want to expand this PR too much.

I can set the window to always resize(via flag) or force the same thing by calling ImGui::SetWindowSize(ImVec2(0,0)) at the start of every draw_controls(), but then the window will resize itself as you switch between tabs.

I'm investigating a better way to handle the sizing.

[CEHA]

On Android I'm can choose only first or last mission in list (((

[RenechCDDA]

On Android I'm can choose only first or last mission in list (((

Please make a bug report (and elaborate there)