Imgui iteminfo - #73456
Merged
Merged
Conversation
mqrause
force-pushed
the
imgui_iteminfo
branch
3 times, most recently
from
May 2, 2024 14:51
6862caa to
3e1e202
Compare
db48x
suggested changes
May 3, 2024
db48x
left a comment
Contributor
There was a problem hiding this comment.
Just a couple of small suggestions
Contributor
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered. |
mqrause
force-pushed
the
imgui_iteminfo
branch
from
August 28, 2024 09:03
2ecf93c to
65bf188
Compare
mqrause
marked this pull request as ready for review
August 28, 2024 09:04
mqrause
force-pushed
the
imgui_iteminfo
branch
from
August 28, 2024 09:24
65bf188 to
b4474ba
Compare
db48x
suggested changes
Aug 28, 2024
db48x
left a comment
Contributor
There was a problem hiding this comment.
Feels great! Just two tiny nits :)
mqrause
force-pushed
the
imgui_iteminfo
branch
from
August 28, 2024 11:54
b4474ba to
9fce736
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Interface "Add imgui version of the iteminfo window"
Purpose of change
Part of the migration to imgui UIs. I specifically need this for #55503, but it's standalone and used in many other places, too, so it gets a separate PR.
Describe the solution
Add an imgui version of iteminfo, both as a separate window and as separate controls available for embedding in already existing imgui windows.
Use the separate window for examining items in the inventory selector, AIM and crafting menu.
Still have to work out some issues.
executemethod.Describe alternatives you've considered
Going further with the migration of this, but I'm mainly doing this for #55503, and this does all I need for that plus some simple examples.
Testing
Examined items in the aforementioned menus.
Additional context
Other menus that display iteminfo, but that need proper migrations to use it:
Vmenu to ImGui #55503)Examine in inventory:

Examine in crafting menu:

Examine in AIM:

(Examining worn/wielded items still uses the old version since it's different.)