Skip to content

Migrate compare item menu to imgui - #78557

Merged
Maleclypse merged 1 commit into
CleverRaven:masterfrom
mqrause:imgui_compare_items
Dec 17, 2024
Merged

Migrate compare item menu to imgui#78557
Maleclypse merged 1 commit into
CleverRaven:masterfrom
mqrause:imgui_compare_items

Conversation

@mqrause

@mqrause mqrause commented Dec 14, 2024

Copy link
Copy Markdown
Contributor

Summary

Interface "Migrate compare item menu to imgui"

Purpose of change

Just another menu I need for #55503.

Describe the solution

The iteminfo work was already done, so this was mostly getting the layout right.
Attach/detach gunmods has buttons now.

Describe alternatives you've considered

Testing

Compared some items through V menu and attached/detached some mods.

Additional context

grafik

@moxian moxian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some irrelevant nitpicks, feel free to ignore (I'm helping!)

Thanks!

Comment thread src/game_inventory.cpp Outdated
Comment thread src/game_inventory.cpp Outdated
Comment thread src/game_inventory.cpp Outdated
@github-actions github-actions Bot added Info / User Interface Game - player communication, menus, etc. Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [C++] Changes (can be) made in C++. Previously named `Code` astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Dec 14, 2024
@mqrause
mqrause force-pushed the imgui_compare_items branch from 7d028fe to 2272d2a Compare December 14, 2024 12:54
@github-actions github-actions Bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 14, 2024
@Maleclypse
Maleclypse merged commit 32e2b3c into CleverRaven:master Dec 17, 2024
@mqrause
mqrause deleted the imgui_compare_items branch December 17, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants