Skip to content

PR Request Conventions

Michelle Tan edited this page Aug 2, 2019 · 1 revision

Before submitting a pull request and when reviewing it, ensure:

  • The latest master branch has been merged.
  • There are tests covering all changes.
  • The build and all tests pass.
  • There are not any changes to other areas of the codebase (out of scope).
  • The pull request has been tested locally or on the PR deployment (#.pr.dx2.co.nz).

The code meets our quality standards:

  • No redundant or duplicate code.
  • As modular as possible.
  • There is documentation for complex areas and library functions.
  • Text is wrapped or truncated if too long.

Clone this wiki locally