Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add needed macOS shortcuts #4851

Merged
merged 2 commits into from Feb 25, 2019

Conversation

Projects
None yet
2 participants
@tresf
Copy link
Member

commented Feb 24, 2019

  • Configures Qt::Key_Backspace (i.e. what Mac calls Delete) the ability to behave like the regular PC Del key.
  • Configures Shift + Return (and subsequently, Shift + Enter ) to behave like Shift + Ins for inserting bars in the SongEditor (credits to @lookitsnicholas in #4526 for the key combinations)
  • Configures Shift + Qt::Key_Backspace (i.e. what Mac calls Delete) to behave like Shift + Del for deleting bars in the SongEditor

Note, this will allow PC users to use these shortcuts as well. I didn't find any code conflicts (e.g. other uses of Backspace/Enter) that suggests this is a bad idea. The consistency will have the added benefit of edge-cases with mixed hardware too (e.g. PC keyboard on Mac, Mac keyboard on PC). I can't find any downside to providing both.

Previously there was no way to perform these operations on an Apple keyboard.

Closes #4522
Supersedes #4526

@tresf tresf added this to the 1.2.0 milestone Feb 24, 2019

@jasp00
Copy link
Member

left a comment

Ignoring maximum line length, it looks good.

@tresf tresf merged commit e34f75a into LMMS:stable-1.2 Feb 25, 2019

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tresf tresf deleted the tresf:delete branch Feb 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.