Conversation
Don't show in changelog
…these resources (4ian#8513) - It only happens when "Unload at scene exit" is selected in project settings and a global object share some resources with a scene object.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
* Make the home page navigation sidebar collapsible * Fix potential crashes in the scene editor * Improve logs in case of UseAfterFreeError Only show in developer changelog * Fix potential crashes in the scene editor Don't show in changelog * Display extension details side by side with the extension list on large screens (4ian#8482) * Fix hot-reloading of global object instances (4ian#8489) * Fix "Add or edit variables" button always creating variables for object variables (4ian#8493) * Fix "Add or edit variables" button opening scene variables instead of local variables (4ian#8496) * Add save/restore support for linked object relationships (4ian#8499) Fix 4ian#8497 * Fix potential crash during resource reloading (4ian#8500) * Make clear in Storage actions if a number or text is being written (4ian#8498) * Add "Reload Project" menu action (4ian#8501) * Remove deprecated, unused GitHub workflow Don't show in changelog * Fix scene properties not usable via the variable action and condition (4ian#8504) * [Auto PR] Update translations (4ian#8474) * Bump newIDE version * Add experimental option in tabs context menu to open some editors (Event Sheets, Extensions...) into separate windows (4ian#8492) * Fix wavesurfer version (4ian#8508) * Allow AI to create objects via exact asset ID without specifying type (4ian#8509) * Fix crashes when using invalid object names in object folders * Support partial asset ID matching in asset search (4ian#8512) Don't show in changelog * Fix missing globally used resources when unloading a scene that uses these resources (4ian#8513) - It only happens when "Unload at scene exit" is selected in project settings and a global object share some resources with a scene object. * Fix tentatively crash in popped-out window when a theme is missing a color (4ian#8518) Fix 4ian#8517 --------- Co-authored-by: Florian Rival <Florian.rival@gmail.com> Co-authored-by: D8H <Davy.Helard@gmail.com> Co-authored-by: LuniMoon <103995399+LuniMoon@users.noreply.github.com> Co-authored-by: Gleb Volkov <glebusheg@playtika.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 56b3e64803
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Allow blank-URL pop-out windows (used by WindowPortal for editor pop-outs), | ||
| // but open all other URLs in the external browser. | ||
| newWindow.webContents.setWindowOpenHandler(details => { | ||
| if (details.frameName.startsWith('GDevelopWindowPortal')) { |
There was a problem hiding this comment.
The setWindowOpenHandler branch currently allows any details.url as long as the frame name starts with GDevelopWindowPortal, even though this path is meant only for the internal about:blank pop-out portal window. In practice, window.open('https://...','GDevelopWindowPortal...') will now open that remote page inside Electron instead of routing externally, and did-create-window later enables @electron/remote for the child window. This creates an unintended in-app window path for non-blank URLs and should be gated on details.url being blank/about:blank before returning action: 'allow'.
Useful? React with 👍 / 👎.
| .catch(error => { | ||
| console.error('PoppedOutMonacoEditor: failed to load Monaco:', error); | ||
| }); |
There was a problem hiding this comment.
When Monaco fails to load in a popped-out editor, the catch branch only logs the error and never updates component state. Because loading remains true, the placeholder spinner is shown indefinitely with no recovery path, leaving the popped-out code editor unusable for that window (for example if the loader script fails to fetch or initialize). This should transition to an error state and expose a retry/fallback path like the main code editor does.
Useful? React with 👍 / 👎.
4 participants
Uh oh!
There was an error while loading. Please reload this page.