Last almost stable (#54)#55
Conversation
* Make the home page navigation sidebar collapsible * Fix potential crashes in the scene editor * Improve logs in case of UseAfterFreeError Only show in developer changelog * Fix potential crashes in the scene editor Don't show in changelog * Display extension details side by side with the extension list on large screens (4ian#8482) * Fix hot-reloading of global object instances (4ian#8489) * Fix "Add or edit variables" button always creating variables for object variables (4ian#8493) * Fix "Add or edit variables" button opening scene variables instead of local variables (4ian#8496) * Add save/restore support for linked object relationships (4ian#8499) Fix 4ian#8497 * Fix potential crash during resource reloading (4ian#8500) * Make clear in Storage actions if a number or text is being written (4ian#8498) * Add "Reload Project" menu action (4ian#8501) Co-authored-by: Gleb Volkov <glebusheg@playtika.com> * Remove deprecated, unused GitHub workflow Don't show in changelog * Fix scene properties not usable via the variable action and condition (4ian#8504) * [Auto PR] Update translations (4ian#8474) * Bump newIDE version * Add experimental option in tabs context menu to open some editors (Event Sheets, Extensions...) into separate windows (4ian#8492) * Fix wavesurfer version (4ian#8508) * Allow AI to create objects via exact asset ID without specifying type (4ian#8509) * Fix crashes when using invalid object names in object folders * Support partial asset ID matching in asset search (4ian#8512) Don't show in changelog * Fix missing globally used resources when unloading a scene that uses these resources (4ian#8513) - It only happens when "Unload at scene exit" is selected in project settings and a global object share some resources with a scene object. * Fix tentatively crash in popped-out window when a theme is missing a color (4ian#8518) Fix 4ian#8517 --------- Co-authored-by: Florian Rival <Florian.rival@gmail.com> Co-authored-by: D8H <Davy.Helard@gmail.com> Co-authored-by: LuniMoon <103995399+LuniMoon@users.noreply.github.com> Co-authored-by: Gleb Volkov <glebusheg@playtika.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 354e0093bb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for (const key of Object.keys(shortcuts)) { | ||
| // $FlowFixMe[incompatible-call] | ||
| const commandName: CommandName = (key: any); | ||
| preferences.setShortcutForCommand(commandName, shortcuts[key]); |
There was a problem hiding this comment.
Reject unknown shortcut commands from project settings
applyProjectPreferences currently treats every key in shortcuts as a valid CommandName and writes it into user shortcuts without validation. If gdevelop-settings.yaml contains a typo or unsupported command, that unknown key is later read by the keyboard shortcut handler, which assumes commandsList[commandName] exists and dereferences handledByElectron; pressing that shortcut then throws at runtime. Please guard keys against the known command list before calling setShortcutForCommand.
Useful? React with 👍 / 👎.
| windowTargetIdToBrowserWindowIds.set(details.frameName, childWindow.id); | ||
| childWindow.on('closed', () => { | ||
| windowTargetIdToBrowserWindowIds.delete(details.frameName); |
There was a problem hiding this comment.
Namespace child-window map keys by parent window
This map is keyed only by frameName, but WindowPortal generates names with a renderer-local counter (GDevelopWindowPortal1, etc.). When two top-level GDevelop windows each open their first popped-out editor, they collide on the same key, so the second registration overwrites the first; when one closes, it can delete the other mapping. In that state, titlebar-set-overlay-options can target the wrong child window (or no child) for background/overlay updates.
Useful? React with 👍 / 👎.
Make the home page navigation sidebar collapsible
Fix potential crashes in the scene editor
Improve logs in case of UseAfterFreeError
Only show in developer changelog
Don't show in changelog
Display extension details side by side with the extension list on large screens (Display extension details side by side with the extension list 4ian/GDevelop#8482)
Fix hot-reloading of global object instances (Fix hot-reloading of global object instances 4ian/GDevelop#8489)
Fix "Add or edit variables" button always creating variables for object variables (Fix "Add or edit variables" button always creating variables for object variables 4ian/GDevelop#8493)
Fix "Add or edit variables" button opening scene variables instead of local variables (Fix "Add or edit variables" button opening scene variables instead of local variables 4ian/GDevelop#8496)
Add save/restore support for linked object relationships (Add save/restore support for linked object relationships 4ian/GDevelop#8499)
Fix 4ian#8497
Fix potential crash during resource reloading (Fix potential crash during resource reloading 4ian/GDevelop#8500)
Make clear in Storage actions if a number or text is being written (Reducing verbose copy 4ian/GDevelop#8498)
Add "Reload Project" menu action (Add "Reload Project" menu action 4ian/GDevelop#8501)
Remove deprecated, unused GitHub workflow
Don't show in changelog
Fix scene properties not usable via the variable action and condition (Fix scene properties in the variable action and condition 4ian/GDevelop#8504)
[Auto PR] Update translations ([Auto PR] Update translations 4ian/GDevelop#8474)
Bump newIDE version
Add experimental option in tabs context menu to open some editors (Event Sheets, Extensions...) into separate windows (Experimental option to open some editors (Event Sheets, Extensions...) into separate windows 4ian/GDevelop#8492)
Fix wavesurfer version (Fix wavesurfer version 4ian/GDevelop#8508)
Allow AI to create objects via exact asset ID without specifying type (Allow AI to create objects via exact asset ID without specifying type 4ian/GDevelop#8509)
Fix crashes when using invalid object names in object folders
Support partial asset ID matching in asset search (Support partial asset ID matching in asset search 4ian/GDevelop#8512)
Don't show in changelog
Fix 4ian#8517