Merged
Conversation
- Tag/branch default
- Delete wrfcloud_parallelcluster policy
- Disk space
- Email identity already exists
- Stacks already exist
TODO: Change default branch from develop to main:
- install_bootstrap.sh
- wrfcloud.aws.imagebuilder
* release_v1: Update release-notes.rst Update installation.rst We saw some errors today. Adding code to handle errors more gracefully. - Tag/branch default - Delete wrfcloud_parallelcluster policy - Disk space - Email identity already exists - Stacks already exist Link all of the files in the WRF run directory to the working directory. Update installation.rst # Conflicts: # install_bootstrap.sh # python/src/wrfcloud/aws/imagebuilder.py
…ist, changed display names to discern wind vector/speed and note 3D field
Co-authored-by: Kate Fossell <fossell@ucar.edu>
Co-authored-by: Kate Fossell <fossell@ucar.edu>
… frustration as arm becomes more popular.
* per #141, added logic to estimate optimal core count. Added function to determine smallest and largest grids that can be used when support for multiple domains is added. Currently only the first domain is used to estimate core count * per #141, cleaned up logic to make it easier to modify to support multiple domains, refactored logic into smaller, testable functions * added unit tests for new functionality * log number of cores to use * remove default value for dictionary get to catch error case when required geogrid.e_we/e_sn are not found * refactor to pair up nx/ny values for each domain * refactored to use namedtuple to store domain nx/ny * refactored to return Domain namedtuples instead of list indices * move call to function to calculate optimal number of cores from cores getter instead of setter so we can store the auto compute value * set cores to 0 if set automatically is checked * updated bucket and dist IDs to push web changes * Added a comment. --------- Co-authored-by: David Hahn <>
* Fixing tests in container without pygrib. * Fixed how test teardown deletes DB tables. * Fixing test code. * fixed a few things in the codebuild script * Test commit to trigger build. * Updated to build with latest amazonlinux image. * Updated to build with latest amazonlinux image. * Updates to work with latest amazonlinux image. * version number must be a float * version is for codebuild, not wrfcloud * Docker image must be built on x86_64 * Using full paths to npm and ng. * Paths not set correctly. --------- Co-authored-by: David Hahn <>
* Update UG link to stable version * Update link to codecov
…on to store error logs
…anged check_success logic to set self.success instead of returning success status, changed logic to parse logs when an error is discovered so the log info can be passed to the error handler
…al if application returns a non-zero code
…re saved in S3 to eventually view in UI, search for success string in log file and fail if string is not found
… not found in log file
…lways run, catch return code of slurm sbatch command and added note to fix logic to use subprocess.check_output to get job ID because os.system returns the return code, not the command output
* per #188, restrict the dates that can be selected for Cycle Date in the Launch WRF page to no later than today's date and not before Feb. 26, 2021 because the input data is not available in S3 before that date * per #188, added logic to refresh last selectable date at the start of the next UTC date * use milliseconds instead of seconds
* Progress on model configuration. * Defined the Lambert Conformal Conic projection used by WRF. * Added a fixed width font class for the namelist text editors. Propagate namelist changes from text edit. Added namelist parser and unparser. Setup events appropriately to pass user changes to all other data representations. * Fixed a bug that allowed clusters to keep running after model finished. * Added physics suite presets. Added computation for time_step in wrf namelist. Added default (or template) namelists for new configurations. * Cleaned up the log viewer styling and layout a bit. * Log viewer styling. * Cleaned up some of the code. * Made a function name change. * Added a wall-time of 1 hour to all slurm jobs. If the test is successful, need to change this to 12 hours. * The sbatch timeout worked, so changing to 12 hours and committing. * Hide the log file tree when in mobile mode.
* Add faq section to UG * Remove extra hidden ^P character in installation * Add sphinx-design to gh action documentation.yml * Correct units --------- Co-authored-by: Kate Fossell <you@example.com>
…where so updates are only needed in one place
…e release to prevent issues that could arise if newer packages are used instead
* Updates to documentation release info. * Updated user guide documentation. --------- Co-authored-by: Kate Fossell <you@example.com> Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expected Differences
If yes, please describe:
Pull Request Testing
Describe testing already performed for these changes:
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
Do these changes include sufficient testing updates? [Yes or No]
Will this PR result in changes to the test suite? [Yes or No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [Fill in date].
Pull Request Checklist
Select: Reviewer(s)
Select: Project
Select: Milestone as the version that will include these changes
Select: Development to link to the original development issue.