upgrade nodejs_18 dependents in prevision for upcoming EOL #399749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
13 tasks
github-actions
bot
added
10.rebuild-darwin: 1-10
nix-owners
bot
requested review from
Izorkin,
Ma27,
NyCodeGHG,
TomaSajt,
florian-sanders-cc,
getchoo,
immae,
melvyn2,
ppom0 and
talyz
aduh95
commented
Apr 18, 2025
pkgs/by-name/pu/pulsar/update.mjs
Outdated
Contributor
Author
There was a problem hiding this comment.
I decided to go straight to 22.x because there's nothing in this script that's not using very stable Node.js features, I suspect nodejs_18 was picked because it was the LTS at the time of aa4cf23, so to lower maintenance burden when nodejs_20 gets retired, let's make it target latest LTS instead.
NyCodeGHG
reviewed
Apr 18, 2025
aduh95
force-pushed
the
nodejs-18-so-long
branch
2 times, most recently
from
5684e90 to
c0f2190
Compare
aduh95
changed the title
aduh95
force-pushed
the
nodejs-18-so-long
branch
from
c0f2190 to
be078b1
Compare
Contributor
|
I didn't check if slskd is already compatible with Node.js v20, but opened the discussion upstream. |
13 tasks
Member
|
btw, breaking changes for 25.05 won't be allowed anymore after April 23. |
wegank
added
12.approved-by: package-maintainer
aduh95
force-pushed
the
nodejs-18-so-long
branch
from
be078b1 to
dc8397c
Compare
github-actions
bot
added
10.rebuild-linux: 1-10
Contributor
Author
|
@TomaSajt I've removed redisinsight from this PR to not conflict with your PR |
Contributor
|
Ah I see, I didn't re-check it after your force push. In case the deadline arrives before it is merged you can add it back. |
florian-sanders-cc
approved these changes
Apr 22, 2025
Contributor
florian-sanders-cc
left a comment
florian-sanders-cc
left a comment
There was a problem hiding this comment.
👍 for clever-tools
Thanks for handling this 😉
wegank
added
12.approvals: 3+
Member
|
0x4A6F
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#399426 may not land just now as there are still a couple of packages that are not building, however it's probably a good idea to land those who build without waiting
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.