Spi plugin port count - #1380
Conversation
|
Blocked behind #1358 . Reviewed as s-light/ola@APA102PixelBrightness...s-light:SPIPlugin_PortCount . |
peternewman
left a comment
peternewman
left a comment
There was a problem hiding this comment.
One minor comment, other than that, LGTM.
| static const char SOFTWARE_BACKEND[]; | ||
| static const uint16_t MAX_GPIO_PIN = 1023; | ||
| static const uint16_t MAX_PORT_COUNT = 32; | ||
| static const uint32_t MAX_SPI_SPEED = 32000000; |
There was a problem hiding this comment.
Nit, can we order these to match the main file, i.e. speed first?
|
Would you mind addressing #1358 (comment) in here @s-light . |
peternewman
left a comment
peternewman
left a comment
There was a problem hiding this comment.
LGTM, as mentioned it would be ace to get #1358 (comment) sorted.
|
#1358 (comment) |
peternewman
left a comment
peternewman
left a comment
There was a problem hiding this comment.
One bug, as some of the tests are failing
| sd_irgb_combined.push_back( | ||
| ola::rdm::SlotData::PrimarySlot(ola::rdm::SD_INTENSITY, 0)); | ||
| ola::rdm::SlotData::PrimarySlot(ola::rdm::SD_INTENSITY, | ||
| ola::rdm::DMX_MAX_SLOT_VALUE)); |
There was a problem hiding this comment.
The tests, but curiously only the Linux ones, not OS X, are failing on this line, see https://travis-ci.org/OpenLightingProject/ola/jobs/345754263#L3298
You want ola::DMX_MAX_SLOT_VALUE, or probably just DMX_MAX_SLOT_VALUE with no namespace.
There was a problem hiding this comment.
sorry - did not run the compile&test (was late and iam tired and thought - hey just do it quick ;-) )
i fix it and this time first do the compiles myself before i commit ;-)
There was a problem hiding this comment.
That's fine, that's exactly what the Continuous Integration is there for, we all make mistakes; I certainly do it often enough!
|
done - for me it compiled and testsuite was successfully |
3 participants
fixes #1379
(based this on the APA102 Pixel Brightness Branch... hope that is ok)