Merged
Conversation
This was referenced Apr 22, 2026
Contributor
Author
Prompt To Fix All With AIThis is a comment left during a code review.
Path: apps/code/src/renderer/features/sidebar/components/UpdateBanner.tsx
Line: 7-17
Comment:
**Debug/temporary code left in production**
These lines were marked as `// TEMP` but are included in the PR and will ship to users. With `status` hardcoded to `"ready"`, `version` defaulting to `"v0.99.0"`, and `isEnabled` forced to `true`, every user will see the update banner on every app load regardless of actual update state. The `void realIsEnabled` line confirms the real value is never consulted.
This block must be removed before merging.
How can I resolve this? If you propose a fix, please make it concise.
---
This is a comment left during a code review.
Path: apps/code/src/renderer/features/sidebar/stores/sidebarStore.ts
Line: 1
Comment:
**Store importing from a component**
`sidebarStore` imports `SIDEBAR_MIN_WIDTH` from a React component file. Stores importing from UI components creates an inverted dependency direction — components typically depend on stores, not vice versa. Consider moving the constant to a shared constants file (e.g. `src/renderer/constants/layout.ts`) so both the component and the store can import it without either depending on the other.
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "fix: increase sidebar min width" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+7
to
+17
| const realStatus = useUpdateStore((s) => s.status); | ||
| const realVersion = useUpdateStore((s) => s.version); | ||
| const realIsEnabled = useUpdateStore((s) => s.isEnabled); | ||
| const installUpdate = useUpdateStore((s) => s.installUpdate); | ||
|
|
||
| // TEMP: force-render "ready" banner for visual review of sidebar min-width | ||
| const status = "ready" as typeof realStatus; | ||
| const version = realVersion ?? "v0.99.0"; | ||
| const isEnabled = true; | ||
| void realIsEnabled; | ||
|
|
There was a problem hiding this comment.
These lines were marked as // TEMP but are included in the PR and will ship to users. With status hardcoded to "ready", version defaulting to "v0.99.0", and isEnabled forced to true, every user will see the update banner on every app load regardless of actual update state. The void realIsEnabled line confirms the real value is never consulted.
This block must be removed before merging.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/code/src/renderer/features/sidebar/components/UpdateBanner.tsx
Line: 7-17
Comment:
**Debug/temporary code left in production**
These lines were marked as `// TEMP` but are included in the PR and will ship to users. With `status` hardcoded to `"ready"`, `version` defaulting to `"v0.99.0"`, and `isEnabled` forced to `true`, every user will see the update banner on every app load regardless of actual update state. The `void realIsEnabled` line confirms the real value is never consulted.
This block must be removed before merging.
How can I resolve this? If you propose a fix, please make it concise.| @@ -1,3 +1,4 @@ | |||
| import { SIDEBAR_MIN_WIDTH } from "@components/ResizableSidebar"; | |||
There was a problem hiding this comment.
sidebarStore imports SIDEBAR_MIN_WIDTH from a React component file. Stores importing from UI components creates an inverted dependency direction — components typically depend on stores, not vice versa. Consider moving the constant to a shared constants file (e.g. src/renderer/constants/layout.ts) so both the component and the store can import it without either depending on the other.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/code/src/renderer/features/sidebar/stores/sidebarStore.ts
Line: 1
Comment:
**Store importing from a component**
`sidebarStore` imports `SIDEBAR_MIN_WIDTH` from a React component file. Stores importing from UI components creates an inverted dependency direction — components typically depend on stores, not vice versa. Consider moving the constant to a shared constants file (e.g. `src/renderer/constants/layout.ts`) so both the component and the store can import it without either depending on the other.
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
jonathanlab
force-pushed
the
04-22-fix_increase_sidebar_min_width
branch
from
b638b73 to
430e157
Compare
jonathanlab
force-pushed
the
04-22-fix_git_persist_pr_draft_values
branch
from
e9f285a to
9a2b540
Compare
This was referenced Apr 22, 2026
jonathanlab
force-pushed
the
04-22-fix_increase_sidebar_min_width
branch
from
430e157 to
f88cc92
Compare
This was referenced Apr 22, 2026
charlesvien
force-pushed
the
04-22-fix_git_persist_pr_draft_values
branch
from
9a2b540 to
143dec1
Compare
charlesvien
force-pushed
the
04-22-fix_increase_sidebar_min_width
branch
from
f88cc92 to
25b215d
Compare
adboio
approved these changes
Apr 22, 2026
charlesvien
force-pushed
the
04-22-fix_git_persist_pr_draft_values
branch
from
143dec1 to
4fc6c84
Compare
charlesvien
force-pushed
the
04-22-fix_increase_sidebar_min_width
branch
from
25b215d to
8027df2
Compare
jonathanlab
force-pushed
the
04-22-fix_git_persist_pr_draft_values
branch
from
4fc6c84 to
935de6f
Compare
jonathanlab
force-pushed
the
04-22-fix_increase_sidebar_min_width
branch
from
8027df2 to
6e52943
Compare
jonathanlab
force-pushed
the
04-22-fix_git_persist_pr_draft_values
branch
2 times, most recently
from
e2f8389 to
574aaf3
Compare
jonathanlab
force-pushed
the
04-22-fix_increase_sidebar_min_width
branch
from
6e52943 to
1db72f2
Compare
charlesvien
changed the base branch from
04-22-fix_git_persist_pr_draft_values
to
graphite-base/1824
charlesvien
force-pushed
the
graphite-base/1824
branch
from
574aaf3 to
5cc774e
Compare
charlesvien
force-pushed
the
04-22-fix_increase_sidebar_min_width
branch
from
1db72f2 to
79f4277
Compare
charlesvien
force-pushed
the
04-22-fix_increase_sidebar_min_width
branch
from
79f4277 to
b6575d8
Compare
Member
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1822