fix: immediately run push on commit & push

[jonathanlab]

Closes #1814

[jonathanlab]

• feat: ability to mention folders #1841
• feat: convert pasted links to gh chip, support PRs #1838
• feat: mentions gh issues/pr with # #1834
• fix: let chat pane resize to min width #1826
• fix: make sure cancel actually aborts push #1831
• fix: immediately run push on commit & push #1830 👈 (View in Graphite)
• fix: increase sidebar min width #1824
• fix(git): persist pr draft values #1823
• fix: handle multiline chips, unescape xml #1818
• fix: unify send message submit key behavior #1817
• fix: add back shift-tab support #1805
• fix: handle git-lfs with GIT_LFS_SKIP_SMUDGE #1804
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[greptile-apps]

Prompt To Fix All With AI

This is a comment left during a code review.
Path: apps/code/src/renderer/features/git-interaction/hooks/useGitInteraction.ts
Line: 413-416

Comment:
**Stale `pushMode` closure when commit-push is used**

`runPush()` reads `store.pushMode` from the Zustand snapshot captured at the last React render, but `modal.openPush(...)` updates the Zustand store synchronously via `set()` without triggering a re-render before `runPush()` is called. The component hasn't re-rendered between these two calls, so `store.pushMode` is still the *previously persisted* value.

A concrete failure case: a user previously pushed to a remote repo (`pushMode = "push"` persisted), then switches to a repo without a remote and uses "commit & push". `modal.openPush("publish")` sets the store to `"publish"`, but `runPush()` still reads the stale `"push"` from the closure and calls `trpcClient.git.push` instead of `trpcClient.git.publish`.

The simplest fix is to derive the mode from the same expression used in `openPush` and pass it explicitly:

```typescript
const mode = git.hasRemote ? "push" : "publish";
modal.openPush(mode);
await runPush(mode);
```

…and update `runPush` to accept an optional `mode` parameter, falling back to `store.pushMode` for the standalone push flow.

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (1): Last reviewed commit: "fix: immediately run push on commit & pu..." | Re-trigger Greptile}

[greptile-apps]

Stale pushMode closure when commit-push is used

runPush() reads store.pushMode from the Zustand snapshot captured at the last React render, but modal.openPush(...) updates the Zustand store synchronously via set() without triggering a re-render before runPush() is called. The component hasn't re-rendered between these two calls, so store.pushMode is still the previously persisted value.

A concrete failure case: a user previously pushed to a remote repo (pushMode = "push" persisted), then switches to a repo without a remote and uses "commit & push". modal.openPush("publish") sets the store to "publish", but runPush() still reads the stale "push" from the closure and calls trpcClient.git.push instead of trpcClient.git.publish.

The simplest fix is to derive the mode from the same expression used in openPush and pass it explicitly:

const mode = git.hasRemote ? "push" : "publish";
modal.openPush(mode);
await runPush(mode);

…and update runPush to accept an optional mode parameter, falling back to store.pushMode for the standalone push flow.

Prompt To Fix With AI

This is a comment left during a code review.
Path: apps/code/src/renderer/features/git-interaction/hooks/useGitInteraction.ts
Line: 413-416

Comment:
**Stale `pushMode` closure when commit-push is used**

`runPush()` reads `store.pushMode` from the Zustand snapshot captured at the last React render, but `modal.openPush(...)` updates the Zustand store synchronously via `set()` without triggering a re-render before `runPush()` is called. The component hasn't re-rendered between these two calls, so `store.pushMode` is still the *previously persisted* value.

A concrete failure case: a user previously pushed to a remote repo (`pushMode = "push"` persisted), then switches to a repo without a remote and uses "commit & push". `modal.openPush("publish")` sets the store to `"publish"`, but `runPush()` still reads the stale `"push"` from the closure and calls `trpcClient.git.push` instead of `trpcClient.git.publish`.

The simplest fix is to derive the mode from the same expression used in `openPush` and pass it explicitly:

```typescript
const mode = git.hasRemote ? "push" : "publish";
modal.openPush(mode);
await runPush(mode);
```

…and update `runPush` to accept an optional `mode` parameter, falling back to `store.pushMode` for the standalone push flow.

How can I resolve this? If you propose a fix, please make it concise.

[adboio]

dis legit ?

[charlesvien]

Merge activity

• Apr 23, 11:03 AM UTC: @charlesvien merged this pull request with Graphite.