feat: convert pasted links to gh chip, support PRs

[jonathanlab]

This started as a humble small PR to automatically convert pasted issues into GH issue chips
But then I realise I wanted to support mentioning PRs too, so I refactored the whole thing for that
Closes #1816

[jonathanlab]

• feat: ability to mention folders #1841
• feat: convert pasted links to gh chip, support PRs #1838 👈 (View in Graphite)
• feat: mentions gh issues/pr with # #1834
• fix: let chat pane resize to min width #1826
• fix: make sure cancel actually aborts push #1831
• fix: immediately run push on commit & push #1830
• fix: increase sidebar min width #1824
• fix(git): persist pr draft values #1823
• fix: handle multiline chips, unescape xml #1818
• fix: unify send message submit key behavior #1817
• fix: add back shift-tab support #1805
• fix: handle git-lfs with GIT_LFS_SKIP_SMUDGE #1804
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[greptile-apps]

Prompt To Fix All With AI

This is a comment left during a code review.
Path: apps/code/src/renderer/features/message-editor/utils/githubIssueUrl.ts
Line: 1

Comment:
**Duplicate `GithubRefKind` type (OnceAndOnlyOnce)**

`GithubRefKind` is already defined in `schemas.ts` (as `z.infer<typeof githubRefKindSchema>`) and re-exported from `../types`. Defining it again here means any future change to the canonical definition won't automatically apply here.

```suggestion
import type { GithubRefKind } from "../types";
export type { GithubRefKind };
```

How can I resolve this? If you propose a fix, please make it concise.

---

This is a comment left during a code review.
Path: apps/code/src/main/services/git/schemas.ts
Line: 554-560

Comment:
**Duplicate input/output schemas (OnceAndOnlyOnce)**

`getGithubPullRequestInput` and `getGithubPullRequestOutput` are byte-for-byte identical to `getGithubIssueInput` / `getGithubIssueOutput`. Aliasing avoids the duplication and keeps both procedures in sync if the shape ever changes.

```suggestion
export const getGithubPullRequestInput = getGithubIssueInput;

export const getGithubPullRequestOutput = getGithubIssueOutput;
```

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (1): Last reviewed commit: "feat: convert pasted links to gh chip, s..." | Re-trigger Greptile}

[greptile-apps]

Duplicate GithubRefKind type (OnceAndOnlyOnce)

GithubRefKind is already defined in schemas.ts (as z.infer<typeof githubRefKindSchema>) and re-exported from ../types. Defining it again here means any future change to the canonical definition won't automatically apply here.

Suggested change

	export type GithubRefKind = "issue" | "pr";
	import type { GithubRefKind } from "../types";
	export type { GithubRefKind };

Prompt To Fix With AI

This is a comment left during a code review.
Path: apps/code/src/renderer/features/message-editor/utils/githubIssueUrl.ts
Line: 1

Comment:
**Duplicate `GithubRefKind` type (OnceAndOnlyOnce)**

`GithubRefKind` is already defined in `schemas.ts` (as `z.infer<typeof githubRefKindSchema>`) and re-exported from `../types`. Defining it again here means any future change to the canonical definition won't automatically apply here.

```suggestion
import type { GithubRefKind } from "../types";
export type { GithubRefKind };
```

How can I resolve this? If you propose a fix, please make it concise.

[greptile-apps]

Duplicate input/output schemas (OnceAndOnlyOnce)

getGithubPullRequestInput and getGithubPullRequestOutput are byte-for-byte identical to getGithubIssueInput / getGithubIssueOutput. Aliasing avoids the duplication and keeps both procedures in sync if the shape ever changes.

Suggested change

	export const getGithubPullRequestInput = z.object({
	owner: z.string(),
	repo: z.string(),
	number: z.number().int().positive(),
	});
	export const searchGithubIssuesOutput = z.array(githubIssueSchema);
	export const getGithubPullRequestOutput = githubRefSchema.nullable();
	export const getGithubPullRequestInput = getGithubIssueInput;
	export const getGithubPullRequestOutput = getGithubIssueOutput;

Prompt To Fix With AI

This is a comment left during a code review.
Path: apps/code/src/main/services/git/schemas.ts
Line: 554-560

Comment:
**Duplicate input/output schemas (OnceAndOnlyOnce)**

`getGithubPullRequestInput` and `getGithubPullRequestOutput` are byte-for-byte identical to `getGithubIssueInput` / `getGithubIssueOutput`. Aliasing avoids the duplication and keeps both procedures in sync if the shape ever changes.

```suggestion
export const getGithubPullRequestInput = getGithubIssueInput;

export const getGithubPullRequestOutput = getGithubIssueOutput;
```

How can I resolve this? If you propose a fix, please make it concise.

[charlesvien]

Merge activity

• Apr 23, 11:41 AM UTC: @charlesvien merged this pull request with Graphite.