feat: ability to mention folders

[jonathanlab]

You can now attach/mention folders
Closes #1775

[jonathanlab]

• feat: ability to mention folders #1841 👈 (View in Graphite)
• feat: convert pasted links to gh chip, support PRs #1838
• feat: mentions gh issues/pr with # #1834
• fix: let chat pane resize to min width #1826
• fix: make sure cancel actually aborts push #1831
• fix: immediately run push on commit & push #1830
• fix: increase sidebar min width #1824
• fix(git): persist pr draft values #1823
• fix: handle multiline chips, unescape xml #1818
• fix: unify send message submit key behavior #1817
• fix: add back shift-tab support #1805
• fix: handle git-lfs with GIT_LFS_SKIP_SMUDGE #1804
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[greptile-apps]

Comments Outside Diff (1)

1. apps/code/src/renderer/features/message-editor/components/AttachmentMenu.tsx, line 453 (link)

   navigator.platform is deprecated

   window.navigator.platform was deprecated in the Web Platform spec. In Electron the main process exposes process.platform which is reliable and not subject to any future deprecation. A simple module-level constant would also avoid recomputing this on every render. Consider using window.navigator.userAgent.toLowerCase().includes("windows") or a tRPC call exposing process.platform.

   Prompt To Fix With AI

   This is a comment left during a code review.
   Path: apps/code/src/renderer/features/message-editor/components/AttachmentMenu.tsx
   Line: 453
   
   Comment:
   **`navigator.platform` is deprecated**
   
   `window.navigator.platform` was deprecated in the Web Platform spec. In Electron the main process exposes `process.platform` which is reliable and not subject to any future deprecation. A simple module-level constant would also avoid recomputing this on every render. Consider using `window.navigator.userAgent.toLowerCase().includes("windows")` or a tRPC call exposing `process.platform`.
   
   How can I resolve this? If you propose a fix, please make it concise.

Prompt To Fix All With AI

This is a comment left during a code review.
Path: apps/code/src/renderer/features/message-editor/suggestions/getSuggestions.ts
Line: 96-97

Comment:
**Folder chip label gains trailing `/` that is lost on XML round-trip**

When a folder chip is created here its label is `parentDirLabel(...)` + `"/"` (e.g. `"src/sub/"`). But `chipFromTag` reconstructs the chip via `deriveFileLabel(path)`, which never appends the slash, so the displayed label silently changes to `"src/sub"` after any XML serialise → deserialise cycle (e.g. task history reload). Either drop the trailing slash from the suggestion label, or add it in `chipFromTag` when tag === `"folder"`, so the two paths agree.

```suggestion
        ? parentDirLabel(file.dir, file.name)
        : parentDirLabel(file.dir, file.name),
```

How can I resolve this? If you propose a fix, please make it concise.

---

This is a comment left during a code review.
Path: apps/code/src/renderer/hooks/useRepoFiles.ts
Line: 92-95

Comment:
**`fzfCache` keyed only on `repoPath` — mode not part of the key**

The cache stores one entry per `repoPath`. Any two callers that pass different `includeDirectories` values for the same repo will continuously invalidate each other's entry: the check at lines 116-119 compares the flag, misses, and overwrites. Today only `getSuggestions.ts` calls `fetchRepoFiles` (always with `includeDirectories: true`), so this is harmless, but the cache will silently degrade if a second caller is added. Consider composing the key from both `repoPath` and `includeDirectories` to make the constraint explicit.

How can I resolve this? If you propose a fix, please make it concise.

---

This is a comment left during a code review.
Path: apps/code/src/renderer/features/message-editor/components/AttachmentMenu.tsx
Line: 453

Comment:
**`navigator.platform` is deprecated**

`window.navigator.platform` was deprecated in the Web Platform spec. In Electron the main process exposes `process.platform` which is reliable and not subject to any future deprecation. A simple module-level constant would also avoid recomputing this on every render. Consider using `window.navigator.userAgent.toLowerCase().includes("windows")` or a tRPC call exposing `process.platform`.

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (1): Last reviewed commit: "feat: ability to mention folders" | Re-trigger Greptile}

[greptile-apps]

Folder chip label gains trailing / that is lost on XML round-trip

When a folder chip is created here its label is parentDirLabel(...) + "/" (e.g. "src/sub/"). But chipFromTag reconstructs the chip via deriveFileLabel(path), which never appends the slash, so the displayed label silently changes to "src/sub" after any XML serialise → deserialise cycle (e.g. task history reload). Either drop the trailing slash from the suggestion label, or add it in chipFromTag when tag === "folder", so the two paths agree.

Suggested change

	label: isDirectory
	? `${parentDirLabel(file.dir, file.name)}/`
	? parentDirLabel(file.dir, file.name)
	: parentDirLabel(file.dir, file.name),

Prompt To Fix With AI

This is a comment left during a code review.
Path: apps/code/src/renderer/features/message-editor/suggestions/getSuggestions.ts
Line: 96-97

Comment:
**Folder chip label gains trailing `/` that is lost on XML round-trip**

When a folder chip is created here its label is `parentDirLabel(...)` + `"/"` (e.g. `"src/sub/"`). But `chipFromTag` reconstructs the chip via `deriveFileLabel(path)`, which never appends the slash, so the displayed label silently changes to `"src/sub"` after any XML serialise → deserialise cycle (e.g. task history reload). Either drop the trailing slash from the suggestion label, or add it in `chipFromTag` when tag === `"folder"`, so the two paths agree.

```suggestion
        ? parentDirLabel(file.dir, file.name)
        : parentDirLabel(file.dir, file.name),
```

How can I resolve this? If you propose a fix, please make it concise.

[greptile-apps]

fzfCache keyed only on repoPath — mode not part of the key

The cache stores one entry per repoPath. Any two callers that pass different includeDirectories values for the same repo will continuously invalidate each other's entry: the check at lines 116-119 compares the flag, misses, and overwrites. Today only getSuggestions.ts calls fetchRepoFiles (always with includeDirectories: true), so this is harmless, but the cache will silently degrade if a second caller is added. Consider composing the key from both repoPath and includeDirectories to make the constraint explicit.

Prompt To Fix With AI

This is a comment left during a code review.
Path: apps/code/src/renderer/hooks/useRepoFiles.ts
Line: 92-95

Comment:
**`fzfCache` keyed only on `repoPath` — mode not part of the key**

The cache stores one entry per `repoPath`. Any two callers that pass different `includeDirectories` values for the same repo will continuously invalidate each other's entry: the check at lines 116-119 compares the flag, misses, and overwrites. Today only `getSuggestions.ts` calls `fetchRepoFiles` (always with `includeDirectories: true`), so this is harmless, but the cache will silently degrade if a second caller is added. Consider composing the key from both `repoPath` and `includeDirectories` to make the constraint explicit.

How can I resolve this? If you propose a fix, please make it concise.

[charlesvien]

Merge activity

• Apr 23, 11:51 AM UTC: @charlesvien merged this pull request with Graphite.