Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1488. There are 3 categories of changes here (divided in blocks in the ChangeLog):
GenericProxyconstructor inmacros/interface.h, which is inherited by pretty much everything, but each type has its own constructor that actually checks the SEXP, etc. So by marking theGenericProxyconstructor asexplicit, we tell the compiler that implicit conversions should go through the specific constructors. Same inDataFrameandListOfwith their own generic constructors. Actually theListOfcase was also special in its own way, just like everything there. ;-)R_xlen_tvsint. This is a bit of a mess. There were methods that weren't converted toR_xlen_tlike similar others and now are, and others were the use ofR_xlen_twas unjustified, unnecessary or plainly wrong. Hopefully this brings some more order.This requires full revdeps.
Checklist
R CMD checkstill passes all tests