-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge release v2.6.1 on main #553
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* commit 'e9fa1affd500faafe8ada7ef330385c7adcb8466': Add release notes and bump version Add `truncation=True` to HF Pipelines (#440)
Release 2.6.0
* Add and modify some logging * Cleanup comments and logs * Update azimuth/utils/ml/perturbation_test.py Co-authored-by: Lindsay Brin <lindsay.brin@servicenow.com> --------- Co-authored-by: Lindsay Brin <lindsay.brin@servicenow.com>
* Update python to 3.9 * Resolve TODO * Fix mypy * Update docs --------- Co-authored-by: joseph.marinier <joseph.marinier@servicenow.com>
* Validate positive integers * Change comment into field description * Change thresholds to percentages
since it is used only by `NumberField`
in which case it will show the grayed-out placeholder "null".
It is now more robust to determine which fields are nullable and which ones are not.
on unsuccessful config update
This makes no difference, except avoiding running one unnecessary line of code.
* Modify call to validation module so it uses the task manager and leverage the cache * Reduce batch size in validation module * Rename validation folder * Wait for validation to be done before continuing
and log status updates only when there are some changes.
and in one multiline log to make sure no logs from other processes get inserted in between.
… prevent the app from being terminated.
* Add pid to logs to help debugging * Modify DM so it always load the latest cache * Clean up `load_latest_cache()` - Define `get_time_from_file_name()` instead of duplicating the `.split("_")[-1][:-6]` logic. - Use `except StopIteration` on `cache_file = next(...)` instead of passing a default value to `cache_file = next(..., None)` and then checking for `if not cache_file:`. * Apply suggestions from code review Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com> --------- Co-authored-by: joseph.marinier <joseph.marinier@servicenow.com>
* Add logging to help with config update debugging * Restart client to free memory * Refactor artifact manager to real singleton and remove clear_cache * Adapt based on comments
* Send tasks that require the pipelines to same worker * Move encoder to ArtifactManager * Add memory-profiler to profile the memory usage * Move the encoder out of the ArtifactManager * Adapt based on comments * Assign encoder and model tasks to same worker * Fix similarity test * Add worker to custom tasks * Add TODO
Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com>
59072dd
to
f366d54
Compare
gabegma
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.