Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.6.0 #519

Merged
merged 172 commits into from
Mar 27, 2023
Merged

Release 2.6.0 #519

merged 172 commits into from
Mar 27, 2023

Conversation

gabegma
Copy link
Contributor

@gabegma gabegma commented Mar 27, 2023

Description:

  • Update so we can release v2.6.0

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

gabegma and others added 30 commits December 6, 2022 17:37
#301)

* Add persistent_id in the config instead of idx

* Add persistent_id if not present in the dataset

* Add filtering on row_idx and persistent_id

* Change based on review

* Apply suggestions from code review

Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com>

* Fix merge

* Change based on review

Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com>
Bumps [express](https://github.com/expressjs/express) from 4.17.1 to 4.17.3.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.17.1...4.17.3)

---
updated-dependencies:
- dependency-name: express
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update webapp_ci.yml

* Update docs_cd.yml

* Update docker_cd.yml
* Update README.md

* Update README.md

Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com>

Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com>
* Clean up test utterances
  - Split into unit tests
  - Assert that responses are sorted
* Test sort without postprocessing
* Fix sort without postprocessing
  - Fix sort confidence or prediction without postprocessing while also simplifying the mapping from `UtterancesSortableColumn` to the actual dataset column, since it's no longer 1:1 (it now depends on `without_postprocessing`).
* Polish comment
and iOS browsers as they don't support lookbehind is regular expressions.
and clean up regular expression
Bumps [wheel](https://github.com/pypa/wheel) from 0.35.1 to 0.38.1.
- [Release notes](https://github.com/pypa/wheel/releases)
- [Changelog](https://github.com/pypa/wheel/blob/main/docs/news.rst)
- [Commits](pypa/wheel@0.35.1...0.38.1)

---
updated-dependencies:
- dependency-name: wheel
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [setuptools](https://github.com/pypa/setuptools) from 50.3.0 to 65.5.1.
- [Release notes](https://github.com/pypa/setuptools/releases)
- [Changelog](https://github.com/pypa/setuptools/blob/main/CHANGES.rst)
- [Commits](pypa/setuptools@v50.3.0...v65.5.1)

---
updated-dependencies:
- dependency-name: setuptools
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [certifi](https://github.com/certifi/python-certifi) from 2021.10.8 to 2022.12.7.
- [Release notes](https://github.com/certifi/python-certifi/releases)
- [Commits](certifi/python-certifi@2021.10.08...2022.12.07)

---
updated-dependencies:
- dependency-name: certifi
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [joblib](https://github.com/joblib/joblib) from 1.1.0 to 1.2.0.
- [Release notes](https://github.com/joblib/joblib/releases)
- [Changelog](https://github.com/joblib/joblib/blob/master/CHANGES.rst)
- [Commits](joblib/joblib@1.1.0...1.2.0)

---
updated-dependencies:
- dependency-name: joblib
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Exclude desired fields from cache hash by setting an extra parameter `exclude_from_cache=True`. This allows for more granular control over which config fields (when they are edited) will trigger some modules to recompute. For example, we don't need to recompute the predictions if a pipeline's name changes, so we add `exclude_from_cache=True` to the `name` field.

Co-authored-by: gabrielle.gm <gabrielle.gm@servicenow.com>
Co-authored-by: Nandhini Babu <nandhini.babu@servicenow.com>
Co-authored-by: Gabrielle Gauthier Melancon <gabrielle.gm@servicenow.com>
* Add new start-up tasks

* Remove prediction from dep for class overlap

* Fix issue with modules with DatasetSplitName.all

* Change based on review

* Update azimuth/startup.py

Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com>

Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com>
* Fix neighbors tagging when no train

* Fix custom_metrics_info route

* Fix class overlap with no train

* Fix test
Bumps [oauthlib](https://github.com/oauthlib/oauthlib) from 3.2.0 to 3.2.1.
- [Release notes](https://github.com/oauthlib/oauthlib/releases)
- [Changelog](https://github.com/oauthlib/oauthlib/blob/master/CHANGELOG.rst)
- [Commits](oauthlib/oauthlib@v3.2.0...v3.2.1)

---
updated-dependencies:
- dependency-name: oauthlib
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [protobuf](https://github.com/protocolbuffers/protobuf) from 3.19.4 to 3.19.5.
- [Release notes](https://github.com/protocolbuffers/protobuf/releases)
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/generate_changelog.py)
- [Commits](protocolbuffers/protobuf@v3.19.4...v3.19.5)

---
updated-dependencies:
- dependency-name: protobuf
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Save modules metadata

* Change based on review
in a proper temporary file.
The `expect(link.href).toContain(...)` wasn't actually testing anything. With `link="https://servicenow.github.io/azimuth/"`, the resulting `href` ended up being `https://servicenow.github.io/azimuth/main/https://servicenow.github.io/azimuth/`, so of course it contained `https://servicenow.github.io/azimuth/`. This test would pass even if we changed the base documentation URL.

Solution: Let's assert equality instead of `toContain`.
gabegma and others added 25 commits March 17, 2023 09:50
* Allow user to change dask cluster from route

* Update azimuth/routers/config.py

Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com>

---------

Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com>
Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com>
- `COMPOSE_EXT` used to overwrite the `-f docker-compose.yml` by specifying a second `-f docker-compose-gpu.yml`, which (fortunately) made `docker-compose` "forget" about the first file. This undocumented behavior is not straightforward and makes our `Makefile` confusing. I propose making `COMPOSE_EXT` only handle the `-gpu` part of the file name.
- Calling `docker-compose` suggests to use `docker compose` instead.
* Handle validation errors and internal errors like `HTTPException`s with a JSON body `{"detail": "..."}`
* Adjust OpenAPI spec (and generated types)
* Make config validation errors human-readable by calling `str(e)` instead of `e.json()`.
* Split `load_azimuth_config` into two single-responsibility methods

* Avoid parsing the whole config prematurely by initially only parsing the `artifact_path`, and parsing the whole config only if it is not loaded from the config history. This avoids irrelevant parsing errors for fields that would be taken from the config history anyway, and it allows for defining required fields in the config.
This reverts commit 7e2fcb0.

Only keeping `docker compose` instead of `docker-compose`.
* Support serving the front end in HTTPS
* Stop exposing the back end's port in `docker-compose.yml` and have the front end call the back end using Docker Compose's internal network. So, when using Docker Compose (`make launch`), the back-end API will only be accessible through the front-end proxy (for example, the Swagger UI will be at http://localhost:8080/api/local/docs). This way, if you use HTTPS to secure the front end (by setting env vars `HTTPS_KEY` and `HTTPS_CERT`), the back end will be secured too.
* Put loading and error states inside the `Dialog` box

* Render PageHeader in only one place (as opposed to once in `BasicLayout` and once in `Exploration`) so that the config modal stays in place if we use the browser back and forward buttons, to avoid losing unsaved changes in the config.

* Resolve warning
* Save config only when different from last config in history

* Change save_config function to method

* Adapt based on comments

* Update azimuth/config.py

Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com>

* Adapt based on comments

---------

Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com>
* Separate Docker build in two GitHub actions

* Join two deployment jobs in one workflow

---------

Co-authored-by: joseph.marinier <joseph.marinier@servicenow.com>
since `env` vars don't work as `make` arguments.
Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com>
…oject section (#505)

Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com>
* Update numpy to 1.23.5

* Add to release notes

* Update torchvision to 0.14.1

* Tolerate small numerical imprecisions
* Enable dask dashboard

* Add lock in artifact manager

* Modify task_id method and key for debugging and consistency

* Adapt based on comments
@JosephMarinier JosephMarinier changed the title Update releases Release 2.6.0 Mar 27, 2023
@gabegma gabegma merged commit 296513d into releases Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants