[instrument_manager] [Multilingual] Translate instrument_manager in french#10763
Open
HachemJ wants to merge 6 commits into
Open
[instrument_manager] [Multilingual] Translate instrument_manager in french#10763HachemJ wants to merge 6 commits into
HachemJ wants to merge 6 commits into
Conversation
github-actions
Bot
added
Language: Javascript
HachemJ
added
the
29.0.0 - Bugs
Open
29 tasks
HachemJ
commented
Jul 10, 2026
| } catch (\NotFound $e) { | ||
| return (new \LORIS\Http\Response\JSON\NotFound( | ||
| $e->getMessage() | ||
| dgettext("instrument_manager", $e->getMessage()) |
Contributor
Author
There was a problem hiding this comment.
Same concern as described in my other PR #10863 (comment)
HachemJ
commented
Jul 10, 2026
| } catch (\Exception $e) { | ||
| return new \LORIS\Http\Response\JSON\InternalServerError( | ||
| $e->getMessage() | ||
| dgettext("instrument_manager", $e->getMessage()) |
Contributor
Author
There was a problem hiding this comment.
Same concern as described in my other PR #10863 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
This PR turns the instrument_manager module into multilingual. However, the only language in which it is translated yet is french.
Link(s) to related issue(s)