[login] Add missing translations#10863
Open
HachemJ wants to merge 7 commits into
Open
Conversation
github-actions
Bot
added
Language: PHP
HachemJ
added
the
29.0.0 - Bugs
Open
29 tasks
HachemJ
commented
Jul 9, 2026
| } catch (\InvalidArgumentException $e) { | ||
| return new \LORIS\Http\Response\JSON\Conflict( | ||
| $e->getMessage() | ||
| dgettext('login', $e->getMessage()) |
Contributor
Author
There was a problem hiding this comment.
I'm not sure about this change because I can’t tell in advance what $e->getMessage() contains. If it returns generic LORIS error messages rather than login specific ones, the translation domain should be loris instead of login. If it can returns both generic LORIS messages and login ones, then it doesn't really work, unless we duplicate these generic error messages from the loris locale to the login one.
This was referenced Jul 10, 2026
github-actions
Bot
added
the
Language: Javascript
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
This PR adds missing translations mainly of error messages. It also removes unnecessary line wrapping from the chinese translation file, as the 80 character line length limit do not apply to it as it would cause false positives in the language validation script that will be added to the CI pipeline #10739 soon.
Link(s) to related issue(s)