[data_release] Add missing translations + adapted code#10772
Open
HachemJ wants to merge 7 commits into
Open
Conversation
github-actions
Bot
added
Language: PHP
HachemJ
added
the
29.0.0 - Bugs
driusan
reviewed
Jul 7, 2026
| msgstr "ファイルの管理" | ||
|
|
||
| msgid "Unversioned" | ||
| msgstr "バージョン管理対象外" |
Collaborator
There was a problem hiding this comment.
Google Translate says this means "Not Under Version Control" which seems a little suspicious.
It translates "Unversioned" as "バージョンなし" (which translates back to English as "Version None") which might be more accurate for a file since this isn't about using a version control system?
I'm not fluent enough in Japanese to say which sounds more natural but intuitively the Google Translate version seems to match the usage here more closely.
Open
29 tasks
HachemJ
commented
Jul 10, 2026
| // the downloaddir. | ||
| return new \LORIS\Http\Response\JSON\InternalServerError( | ||
| $e->getMessage() | ||
| dgettext("data_release", $e->getMessage()) |
Contributor
Author
There was a problem hiding this comment.
Same concern as described in my other PR #10863 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
This PR adds missing translation of the
data_releasemodule and fixes a french translation requested in the issue.For the 'Unversioned' related code changes, I would prefer if someone could confirm that I updated the correct query for the user-facing translation and that I didn’t miss any related code paths that should be changed or introduce any regressions.
Note: I used DeepL (AI) to translate the strings in hindi, japanese and chinese.
Link(s) to related issue(s)