[imaging_uploader] Add missing translations by HachemJ · Pull Request #10973 · aces/Loris

HachemJ · 2026-07-21T19:57:07Z

Brief summary of changes

This PR adds the missing translations requested in the corresponding issue except for the Spanish ones. I decided not to include any Spanish translations because the Spanish locale does not exist in this module and it is outside the scope of the 29.0.0 release.

Testing instructions (if applicable)

Go to 'Imaging' -> 'Imaging Uploader'
Switch the language to French, Japanese and Chinese
Verify the added translations and report missing ones if found while reviewing the PR.

Issue ID: closes #10952

lapadulamichael · 2026-07-22T18:24:02Z

Waiting on this PR to be merged since it is critical to release and will enter in conflict with this one

HachemJ · 2026-07-22T18:59:16Z

Waiting on this PR to be merged since it is critical to release and will enter in conflict with this one

#10979

you meant this PR right?
because the one you linked #10983 doesn't conflict with this one. It doesn't modify the same files.

lapadulamichael · 2026-07-22T19:03:10Z

Waiting on this PR to be merged since it is critical to release and will enter in conflict with this one

#10979

you meant this PR right? because the one you linked #10983 doesn't conflict with this one. It doesn't modify the same files.

Yes sorry, edited my comment

driusan · 2026-07-22T19:57:32Z

The blocking PR is now merged

HachemJ · 2026-07-22T23:09:29Z

Ready for final review. @lapadulamichael

HachemJ · 2026-07-23T14:06:04Z

@lapadulamichael I had to resolve new conflicts. Can you approve now? Thanks

lapadulamichael · 2026-07-23T14:40:11Z

Since the file was not modified I cannot "Suggest a change".

Japanese translation for "Logs to display" is incomplete. Should be -> "表示するログ"

lapadulamichael

Translations look good. Small cleanup/correction to do.

Only issue is that the data table won't load after switching language. It seems to be related to the URL containing the lang label (Ex. lang=en-CA). The translations and the table load correctly when the label is not there

lapadulamichael · 2026-07-23T14:58:55Z

@HachemJ The bug I mentioned seems to be related to 10897 and 10890

HachemJ · 2026-07-23T15:15:41Z

@HachemJ The bug I mentioned seems to be related to 10897 and 10890

this bug you're talking about was mentioned in here too #10945

i think that it is outside the scope of this PR. I can fix the other stuff you mentioned i think they are relevant and can be included in this PR.

lapadulamichael · 2026-07-23T15:16:59Z

@HachemJ The bug I mentioned seems to be related to 10897 and 10890

this bug you're talking about was mentioned in here too #10945

i think that it is outside the scope of this PR. I can fix the other stuff you mentioned i think they are relevant and can be included in this PR.

I agree, since it's an unrelated bug we shouldn't include it in this PR

HachemJ · 2026-07-23T16:07:34Z

@lapadulamichael ready for final review after having applied your changes.

lapadulamichael · 2026-07-23T17:32:33Z

@HachemJ Just missing the cleanup for genomic_browser.po

… got merged

… to LORIS namespace and adapting code accordingly

…upload' present in LORIS namespace

HachemJ · 2026-07-23T18:27:03Z

One last time @lapadulamichael . Thanks again

lapadulamichael

LGTM

github-actions Bot added Language: Javascript PR or issue that update Javascript code Module: imaging_uploader PR or issue related to imaging_uploader module Multilingual Any tasks related to making LORIS multilingual labels Jul 21, 2026

HachemJ added the 29.0.0 - Bugs Issues found during the release testing for 29.0.0 label Jul 21, 2026

driusan assigned lapadulamichael Jul 21, 2026

lapadulamichael self-requested a review July 22, 2026 14:50

lapadulamichael added the State: Blocked PR or issue awaiting an external event such as the merge or another PR to proceed label Jul 22, 2026

driusan removed the State: Blocked PR or issue awaiting an external event such as the merge or another PR to proceed label Jul 22, 2026

HachemJ force-pushed the AddMissingTranslationInImagingUploader branch 2 times, most recently from 0b397b3 to 841c467 Compare July 22, 2026 23:00

lapadulamichael reviewed Jul 23, 2026

View reviewed changes

Comment thread modules/imaging_uploader/locale/fr/LC_MESSAGES/imaging_uploader.po Outdated

lapadulamichael reviewed Jul 23, 2026

View reviewed changes

Comment thread modules/imaging_uploader/locale/fr/LC_MESSAGES/imaging_uploader.po Outdated

lapadulamichael suggested changes Jul 23, 2026

View reviewed changes

lapadulamichael assigned HachemJ Jul 23, 2026

lapadulamichael added the State: Needs work PR awaiting additional work by the author to proceed label Jul 23, 2026

HachemJ force-pushed the AddMissingTranslationInImagingUploader branch from cf55620 to 55f9d75 Compare July 23, 2026 15:29

github-actions Bot added the Language: PHP PR or issue that update PHP code label Jul 23, 2026

HachemJ force-pushed the AddMissingTranslationInImagingUploader branch 2 times, most recently from d7cd684 to 8e9162c Compare July 23, 2026 16:03

github-actions Bot added the Module: issue_tracker PR or issue related to issue tracker module label Jul 23, 2026

HachemJ removed the State: Needs work PR awaiting additional work by the author to proceed label Jul 23, 2026

HachemJ removed their assignment Jul 23, 2026

HachemJ force-pushed the AddMissingTranslationInImagingUploader branch from b3c7239 to 17a81d9 Compare July 23, 2026 18:10

HachemJ added 6 commits July 23, 2026 14:18

add missing translations

f002202

fix merge conflicts with critical to release imaging_uploader PR that…

ceefe5a

… got merged

uniformizing 'Upload Successful' to 'Upload successful' and moving it…

5cadb3a

… to LORIS namespace and adapting code accordingly

Fix Japanese translation for 'Logs to display'

249cff5

removing 'File to Upload' from this module's locale because 'File to …

687b7aa

…upload' present in LORIS namespace

cleanup genomic_browser.po

1ca4ffc

HachemJ force-pushed the AddMissingTranslationInImagingUploader branch from 0645431 to 1ca4ffc Compare July 23, 2026 18:24

HachemJ requested a review from lapadulamichael July 23, 2026 18:26

lapadulamichael approved these changes Jul 23, 2026

View reviewed changes

lapadulamichael added the Passed manual tests PR has been successfully tested by at least one peer label Jul 23, 2026

driusan merged commit ec659a5 into aces:29.0-release Jul 23, 2026
22 checks passed

Uh oh!

Conversation

HachemJ commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Brief summary of changes

Testing instructions (if applicable)

Issue ID: closes #10952

Uh oh!

lapadulamichael commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HachemJ commented Jul 22, 2026

Uh oh!

lapadulamichael commented Jul 22, 2026

Uh oh!

driusan commented Jul 22, 2026

Uh oh!

HachemJ commented Jul 22, 2026

Uh oh!

HachemJ commented Jul 23, 2026

Uh oh!

Uh oh!

Uh oh!

lapadulamichael commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lapadulamichael left a comment

Choose a reason for hiding this comment

Uh oh!

lapadulamichael commented Jul 23, 2026

Uh oh!

HachemJ commented Jul 23, 2026

Uh oh!

lapadulamichael commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HachemJ commented Jul 23, 2026

Uh oh!

lapadulamichael commented Jul 23, 2026

Uh oh!

HachemJ commented Jul 23, 2026

Uh oh!

lapadulamichael left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HachemJ commented Jul 21, 2026 •

edited

Loading

lapadulamichael commented Jul 22, 2026 •

edited

Loading

lapadulamichael commented Jul 23, 2026 •

edited

Loading

lapadulamichael commented Jul 23, 2026 •

edited

Loading