[imaging_uploader] Fixes for a couple of imaging uploader bugs#10979
Conversation
github-actions
Bot
added
Language: Javascript
nicolasbrossard
changed the title
nicolasbrossard
added
Critical to release
| "Content-Type: text/plain; charset=UTF-8\n" | ||
| "Content-Transfer-Encoding: 8bit\n" | ||
| "X-Generator: Poedit 3.8\n" | ||
| "Plural-Forms: nplurals=2; plural=(n > 1);\n" |
There was a problem hiding this comment.
Why did you remove this header? I think it should be kept
| msgid "" | ||
| "A file with this name already exists! Would you like to overwrite the " | ||
| "existing file?" | ||
| msgstr "" | ||
| "Un fichier portant ce nom existe déjà ! Voulez-vous remplacer le fichier " | ||
| "existant ?" |
There was a problem hiding this comment.
Is this change only about not exceeding the character limit per line?
I don't know if you're doing the line wrapping manually or if you are using a tool to do it when the line exceeds 80 lines but in either way, this should be reverted.
Recently, @driusan told me that it is not necessary to respect this limit because it doesn't apply to the translation files.
The new language completion check script present in tools/language_completion_check.php and recently introduced to the pipeline is responsible of finding mismatches between .po and .pot files. That being said, it understands/supports the former (complete string on the same line after msgid) format better and will now detect false positives.
| msgid "" | ||
| "A file with this name has been uploaded but has not yet been processed by " | ||
| "the MRI pipeline. Would you like to overwrite the existing file?" | ||
| msgstr "" | ||
| "Un fichier portant ce nom a été téléversé, mais n'a pas encore été traité " | ||
| "par le pipeline IRM. Souhaitez-vous remplacer le fichier existant ?" |
There was a problem hiding this comment.
| msgid "" | ||
| "For example, for DCCID {{dccid}}, PSCID {{pscid}}, and Visit Label " | ||
| "{{visitLabel}} the file name should be prefixed by: {{prefix}}" | ||
| msgstr "" | ||
| "Par exemple, pour DCCID {{dccid}}, PSCID {{pscid}} et Libellé de visite " | ||
| "{{visitLabel}}, le nom du fichier doit être préfixé par : {{prefix}}" |
There was a problem hiding this comment.
Co-authored-by: Jad El Hachem <156138084+HachemJ@users.noreply.github.com>
Co-authored-by: Jad El Hachem <156138084+HachemJ@users.noreply.github.com>
Co-authored-by: Jad El Hachem <156138084+HachemJ@users.noreply.github.com>
|
@HachemJ Thanks for the review Jad. Ready for round 2! |
HachemJ
left a comment
HachemJ
left a comment
There was a problem hiding this comment.
Everything that was mentioned in the corresponding issue works on my end. The broken links, the display bugs were all resolved. And the code changes make sense.
LGTM
HachemJ
added
the
Passed manual tests
3 participants
This PR performs the following fixes in the imaging uploader module:
Session IDandPatient Nameare now hidden.Progress.Number of Files Created.Fixes #10791