Skip to content

[MWPW-203054] [MWPW-203055] - Additional Manifest and Page Summary fields. - #6446

Merged
milo-pr-merge[bot] merged 6 commits into
stagefrom
mn-manifest-page-labels
Aug 30, 2026
Merged

[MWPW-203054] [MWPW-203055] - Additional Manifest and Page Summary fields.#6446
milo-pr-merge[bot] merged 6 commits into
stagefrom
mn-manifest-page-labels

Conversation

@AdobeLinhart

@AdobeLinhart AdobeLinhart commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Updates

  • [MWPW-203055] Manifest card: replace the single "Mktg Action" row with four flat fields — Geo Restriction, Type, Override Name, Execution Order — pulled from the manifest's info-tab metadata, each showing "none" when blank
  • [MWPW-203054] Page Summary card: replace the "Target Integration" and "Personalization" rows with a new Manifest Sources section containing Target Integration, Personalization Metadata, Promo Metadata, and MEP Param, each as on/off
  • [MWPW-203054] Add a Load Target Faster (v2) row (on/off/n/a) reflecting the personalization-v2 metadata flag, shown as n/a when Target integration is off
  • [MWPW-203054] Nested on/off values (inside Manifest Sources) now get the same emphasis highlight as Consent's on/off rows when the value is "on"
  • Export getPromoMepEnablement from utils.js so the overlay can reuse the existing multi-region promo-metadata detection instead of duplicating it

Instructions

These fields are metadata/param driven, so to see non-default (on) states while testing:

  1. Open the page with ?mepnext=on&mep and ?milolibs=mn-manifest-page-labels to load the new overlay code.
  2. Open the MEP overlay (FAB → Summary tab → Page card) to see Manifest Sources and Load Target Faster (v2).
    • Personalization Metadata is "on" when the page has a personalization metadata tag.
    • Promo Metadata is "on" when the page has a manifestnames (or regional *_manifestnames) metadata tag.
    • MEP Param is "on" when the URL includes a mep query param with a value.
    • Load Target Faster (v2) is "n/a" unless Target integration is on, in which case it reflects the personalization-v2 metadata tag.
  3. Open the Manifests tab and expand a manifest card to see Geo Restriction, Type, Override Name, and Execution Order — these come from the manifest's own info tab and show "none" when not set.

Resolves: MWPW-203054, MWPW-203055

Test URLs:

Integration Off

Integration On

PSI: https://=mn-manifest-page-labels--da-cc--adobecom.aem.page/products/photoshop?martech=off

@aem-code-sync

aem-code-sync Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@github-actions

Copy link
Copy Markdown
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@jpratt2

jpratt2 commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

@AdobeLinhart What do you think of putting a tool tip or hover text over these new fields? Something to explain their source. Something like this: pulled from the manifest's info-tab metadata

@jpratt2
jpratt2 requested a review from skumar09 August 12, 2026 17:22
@jpratt2

jpratt2 commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

@skumar09 In case you're interested, there is a case of a "flaky test" in https://github.com/adobecom/milo/actions/runs/31547667785/job/93963513898?pr=6446 where a locator wasn't able to be clicked. Somehow the test still passed and the nala test detected that it was flaky. I tried limiting workers to 2 prior to this test run, but this still happened, fyi, in case that helps in detecting the cause or if it helps with prescribing some solution code.
image

@jpratt2

jpratt2 commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

@AdobeLinhart
Here are 2 code review items from Claude:
code review - 2

@markpadbe markpadbe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Two small notes(@jpratt2 already flagged the first one), both non-blocking:

1. Metadata on/off reads (L269, L122) — long-standing convention, just flagging
Not an ask on this PR, and definitely not something introduced here — the getMetadata(x) ? 'on' : 'off' idiom goes all the way back to the original MEP Manifest Manager in preview.js, so the new L269 is correctly following how MEP preview tooling has always read these flags. The only wrinkle: getMetadata returns the raw string, so an author writing content="off" would be truthy and render as on. In practice these flags are authored as presence-only, so it basically never bites. If we ever decide to harden it, getMepEnablement('personalization-v2') (utils.js:2145) handles off/other values correctly — the same shape the file already uses at L401 for mas-geo-detection. Fine to leave as-is; noting it only for the record.

2. Commented-out caas badge assertion (mep-next-button.test.js)
Fine as a temporary stopgap to keep CI green. It's a genuine flake with a distinct root cause (the caas badge waits on loadCaas loading React/chimera from www.adobe.com, which the aem.live throttle pacer doesn't cover), so commenting it out here is reasonable. I'll track a potential real fix + re-enable under MWPW-198784.

@AdobeLinhart
AdobeLinhart deployed to milo_pr_merge August 19, 2026 22:52 — with GitHub Actions Active
@AdobeLinhart
AdobeLinhart deployed to milo_pr_merge August 19, 2026 22:52 — with GitHub Actions Active
@milo-pr-merge
milo-pr-merge Bot merged commit e3ee524 into stage Aug 30, 2026
28 of 32 checks passed
@milo-pr-merge
milo-pr-merge Bot deleted the mn-manifest-page-labels branch August 30, 2026 09:43
@milo-pr-merge milo-pr-merge Bot mentioned this pull request Aug 30, 2026
joaquinrivero added a commit that referenced this pull request Aug 31, 2026
* origin/stage: (33 commits)
  INTL1207 - Add content-toggle block for A/B test campaign (#6451)
  Add a guard in decorateAutoBlock for merch links (#6567)
  [MWPW-204859]  - Apply forced-reflow fix to brand-concierge floating (#6510)
  [MWPW-204698] Remove manifest overline (#6496)
  [Milo][Martech] Remove performance consent check from analytics event sending (#6491)
  MWPW-203941: Update authoring pattern for bc marquee (#6490)
  MWPW-204795 [MEP] Remove RainFocus registration-data (event-id) path (#6483)
  [MWPW-204301] [Lingo] MEP replace/remove on mep-lingo fragments + regional replacement resolution (#6474)
  MWPW-202286 Separate mas field from merch card autoblock (#6463)
  [MWPW-203054] [MWPW-203055] - Additional Manifest and Page Summary fields. (#6446)
  MWPW-200965: Port email-collection block to C2 (#6441)
  [MWPW-205693]: Adding rtl change for languageselector (#6581)
  [MWPW-204596] Validate the fedsbranch query parameter in C2 global-navigation (#6497)
  [MWPW-199609] Harden sanitizeHtml URL scheme allowlist (#6475)
  MWPW-204984: Revert eager IMS load (#6511) (#6549)
  MWPW-204984
  [MWPW-204913]: C2 persistent cart (#6522)
  fix for mc autoblock
  MWPW-204875: eagerly load ims
  up to date with main
  ...

# Conflicts:
#	libs/blocks/merch-card-autoblock/merch-card-autoblock.js
#	libs/blocks/merch/merch.js
#	test/blocks/merch-card-autoblock/merch-card-autoblock.test.js
joaquinrivero added a commit that referenced this pull request Aug 31, 2026
* origin/stage: (33 commits)
  INTL1207 - Add content-toggle block for A/B test campaign (#6451)
  Add a guard in decorateAutoBlock for merch links (#6567)
  [MWPW-204859]  - Apply forced-reflow fix to brand-concierge floating (#6510)
  [MWPW-204698] Remove manifest overline (#6496)
  [Milo][Martech] Remove performance consent check from analytics event sending (#6491)
  MWPW-203941: Update authoring pattern for bc marquee (#6490)
  MWPW-204795 [MEP] Remove RainFocus registration-data (event-id) path (#6483)
  [MWPW-204301] [Lingo] MEP replace/remove on mep-lingo fragments + regional replacement resolution (#6474)
  MWPW-202286 Separate mas field from merch card autoblock (#6463)
  [MWPW-203054] [MWPW-203055] - Additional Manifest and Page Summary fields. (#6446)
  MWPW-200965: Port email-collection block to C2 (#6441)
  [MWPW-205693]: Adding rtl change for languageselector (#6581)
  [MWPW-204596] Validate the fedsbranch query parameter in C2 global-navigation (#6497)
  [MWPW-199609] Harden sanitizeHtml URL scheme allowlist (#6475)
  MWPW-204984: Revert eager IMS load (#6511) (#6549)
  MWPW-204984
  [MWPW-204913]: C2 persistent cart (#6522)
  fix for mc autoblock
  MWPW-204875: eagerly load ims
  up to date with main
  ...

# Conflicts:
#	libs/blocks/merch-card-autoblock/merch-card-autoblock.js
#	libs/blocks/merch/merch.js
#	test/blocks/merch-card-autoblock/merch-card-autoblock.test.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready for Stage verified PR has been E2E tested by a reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants