[MWPW-203054] [MWPW-203055] - Additional Manifest and Page Summary fields. - #6446
Conversation
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
32671a7 to
801da35
Compare
|
@AdobeLinhart What do you think of putting a tool tip or hover text over these new fields? Something to explain their source. Something like this: pulled from the manifest's info-tab metadata |
|
@skumar09 In case you're interested, there is a case of a "flaky test" in https://github.com/adobecom/milo/actions/runs/31547667785/job/93963513898?pr=6446 where a locator wasn't able to be clicked. Somehow the test still passed and the nala test detected that it was flaky. I tried limiting workers to 2 prior to this test run, but this still happened, fyi, in case that helps in detecting the cause or if it helps with prescribing some solution code. |
|
@AdobeLinhart |
There was a problem hiding this comment.
Looks good to me. Two small notes(@jpratt2 already flagged the first one), both non-blocking:
1. Metadata on/off reads (L269, L122) — long-standing convention, just flagging
Not an ask on this PR, and definitely not something introduced here — the getMetadata(x) ? 'on' : 'off' idiom goes all the way back to the original MEP Manifest Manager in preview.js, so the new L269 is correctly following how MEP preview tooling has always read these flags. The only wrinkle: getMetadata returns the raw string, so an author writing content="off" would be truthy and render as on. In practice these flags are authored as presence-only, so it basically never bites. If we ever decide to harden it, getMepEnablement('personalization-v2') (utils.js:2145) handles off/other values correctly — the same shape the file already uses at L401 for mas-geo-detection. Fine to leave as-is; noting it only for the record.
2. Commented-out caas badge assertion (mep-next-button.test.js)
Fine as a temporary stopgap to keep CI green. It's a genuine flake with a distinct root cause (the caas badge waits on loadCaas loading React/chimera from www.adobe.com, which the aem.live throttle pacer doesn't cover), so commenting it out here is reasonable. I'll track a potential real fix + re-enable under MWPW-198784.
d20b2f6 to
6aa6dc4
Compare
* origin/stage: (33 commits) INTL1207 - Add content-toggle block for A/B test campaign (#6451) Add a guard in decorateAutoBlock for merch links (#6567) [MWPW-204859] - Apply forced-reflow fix to brand-concierge floating (#6510) [MWPW-204698] Remove manifest overline (#6496) [Milo][Martech] Remove performance consent check from analytics event sending (#6491) MWPW-203941: Update authoring pattern for bc marquee (#6490) MWPW-204795 [MEP] Remove RainFocus registration-data (event-id) path (#6483) [MWPW-204301] [Lingo] MEP replace/remove on mep-lingo fragments + regional replacement resolution (#6474) MWPW-202286 Separate mas field from merch card autoblock (#6463) [MWPW-203054] [MWPW-203055] - Additional Manifest and Page Summary fields. (#6446) MWPW-200965: Port email-collection block to C2 (#6441) [MWPW-205693]: Adding rtl change for languageselector (#6581) [MWPW-204596] Validate the fedsbranch query parameter in C2 global-navigation (#6497) [MWPW-199609] Harden sanitizeHtml URL scheme allowlist (#6475) MWPW-204984: Revert eager IMS load (#6511) (#6549) MWPW-204984 [MWPW-204913]: C2 persistent cart (#6522) fix for mc autoblock MWPW-204875: eagerly load ims up to date with main ... # Conflicts: # libs/blocks/merch-card-autoblock/merch-card-autoblock.js # libs/blocks/merch/merch.js # test/blocks/merch-card-autoblock/merch-card-autoblock.test.js
* origin/stage: (33 commits) INTL1207 - Add content-toggle block for A/B test campaign (#6451) Add a guard in decorateAutoBlock for merch links (#6567) [MWPW-204859] - Apply forced-reflow fix to brand-concierge floating (#6510) [MWPW-204698] Remove manifest overline (#6496) [Milo][Martech] Remove performance consent check from analytics event sending (#6491) MWPW-203941: Update authoring pattern for bc marquee (#6490) MWPW-204795 [MEP] Remove RainFocus registration-data (event-id) path (#6483) [MWPW-204301] [Lingo] MEP replace/remove on mep-lingo fragments + regional replacement resolution (#6474) MWPW-202286 Separate mas field from merch card autoblock (#6463) [MWPW-203054] [MWPW-203055] - Additional Manifest and Page Summary fields. (#6446) MWPW-200965: Port email-collection block to C2 (#6441) [MWPW-205693]: Adding rtl change for languageselector (#6581) [MWPW-204596] Validate the fedsbranch query parameter in C2 global-navigation (#6497) [MWPW-199609] Harden sanitizeHtml URL scheme allowlist (#6475) MWPW-204984: Revert eager IMS load (#6511) (#6549) MWPW-204984 [MWPW-204913]: C2 persistent cart (#6522) fix for mc autoblock MWPW-204875: eagerly load ims up to date with main ... # Conflicts: # libs/blocks/merch-card-autoblock/merch-card-autoblock.js # libs/blocks/merch/merch.js # test/blocks/merch-card-autoblock/merch-card-autoblock.test.js


Updates
personalization-v2metadata flag, shown as n/a when Target integration is offgetPromoMepEnablementfromutils.jsso the overlay can reuse the existing multi-region promo-metadata detection instead of duplicating itInstructions
These fields are metadata/param driven, so to see non-default (on) states while testing:
?mepnext=on&mepand?milolibs=mn-manifest-page-labelsto load the new overlay code.Personalization Metadatais "on" when the page has apersonalizationmetadata tag.Promo Metadatais "on" when the page has amanifestnames(or regional*_manifestnames) metadata tag.MEP Paramis "on" when the URL includes amepquery param with a value.Load Target Faster (v2)is "n/a" unless Target integration is on, in which case it reflects thepersonalization-v2metadata tag.Resolves: MWPW-203054, MWPW-203055
Test URLs:
Integration Off
Integration On
PSI: https://=mn-manifest-page-labels--da-cc--adobecom.aem.page/products/photoshop?martech=off