Skip to content

INTL1207 - Add content-toggle block for A/B test campaign - #6451

Merged
milo-pr-merge[bot] merged 1 commit into
stagefrom
intl1207-content-toggle
Aug 31, 2026
Merged

INTL1207 - Add content-toggle block for A/B test campaign#6451
milo-pr-merge[bot] merged 1 commit into
stagefrom
intl1207-content-toggle

Conversation

@elindseth

@elindseth elindseth commented Aug 11, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

This PR adds new functionality to the content-toggle block that has previously been tested.

New functionality:

  • Config-driven mounting of the toggle nav inside a marquee via Mount target/Mount marker
  • Config-driven default option via Default toggle
  • Config-driven sticky behavior (None / Sticky / Pinned)
  • Config-driven scroll-on-toggle (None / Top / Matched anchor)

Resolves: OPT-42221

Test URLs:

@aem-code-sync

aem-code-sync Bot commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@elindseth
elindseth force-pushed the intl1207-content-toggle branch from 3e43ba8 to 82eda11 Compare August 12, 2026 12:41
@jpratt2

jpratt2 commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

@elindseth Here is a code review from Claude:
No blockers.PR-6451-review.docx

@jpratt2

jpratt2 commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

@elindseth
When I use this URL in a mobile phone emulator in Chrome dev tools, I am noticing that the toggle defaults to "desktop" when I add the new intl1207.json manifest via the MEP button :

defaults to desktop

Is this OK / expected?

https://main--da-cc--adobecom.aem.page/uk/products/premiere?milolibs=intl1207-content-toggle&mep=%2Fuk%2Fcc-shared%2Ffragments%2Froc%2Fmep%2Fproducts%2Fpremiere%2Froc-premiere.json--default---%2Fproducts%2Fpremiere.json--phone---%2Fcc-shared%2Ffragments%2Fpromos%2F2026%2Fglobal%2Ffirefly-crosslinking-banner.json--default---%2Fcc-shared%2Ffragments%2Fpromos%2F2026%2Fglobal%2Ffooter-de-kr%2Fseparate-de.json--default---%2Fcc-shared%2Ffragments%2Fpromos%2F2026%2Fglobal%2Ffooter-de-kr%2Fseparate-kr.json--default
URL for intl1207 manifest: https://main--da-cc--adobecom.aem.page/cc-shared/fragments/tests/emea-latam/2026/q3/intl1207/intl1207.json

@jpratt2

jpratt2 commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Note: I don't expect you to act on all of the suggestions from Claude. There are no blockers, so I consider all of the other suggestions optional.

@elindseth

elindseth commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

@elindseth When I use this URL in a mobile phone emulator in Chrome dev tools, I am noticing that the toggle defaults to "desktop" when I add the new intl1207.json manifest via the MEP button : Is this OK / expected?

@jpratt2 There is an expectation that it starts in desktop for this test campaign. That is how I've parsed the charter anyway. There is a config option to make it default to the second toggle option, but nothing that makes it detect the device. That might be the more logical behaviour, and a good enhancement if this test wins.

The block was initially written for Express vs CC so I didn't consider baking in any such mobile enhancements. Maybe I should have. :)

@elindseth
elindseth force-pushed the intl1207-content-toggle branch from b1bb603 to 469b507 Compare August 19, 2026 10:49
@elindseth
elindseth force-pushed the intl1207-content-toggle branch from 469b507 to d3b8e7a Compare August 19, 2026 15:17
@elindseth
elindseth force-pushed the intl1207-content-toggle branch from d3b8e7a to 03af68e Compare August 19, 2026 16:35
@elindseth
elindseth force-pushed the intl1207-content-toggle branch 2 times, most recently from 8abeb0e to fca767a Compare August 20, 2026 12:23
jpratt2
jpratt2 approved these changes Aug 24, 2026
View reviewed changes

@jpratt2 jpratt2 left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved
I can verify that the toggle works in a mobile device to switch content when clicked.
Claude didn't find any blockers
link

Image

@elindseth
elindseth force-pushed the intl1207-content-toggle branch 2 times, most recently from 6b9bf55 to e6986c6 Compare August 26, 2026 01:05
@elindseth
elindseth force-pushed the intl1207-content-toggle branch 2 times, most recently from 634e11e to b468b75 Compare August 28, 2026 15:22
@seprakas
seprakas self-requested a review August 28, 2026 15:24
seprakas
seprakas approved these changes Aug 28, 2026
View reviewed changes

@seprakas seprakas left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!
I see the toggle working fine with the preview link.

Image

@elindseth
elindseth force-pushed the intl1207-content-toggle branch from b468b75 to 9172632 Compare August 30, 2026 22:37
@elindseth
elindseth force-pushed the intl1207-content-toggle branch from 9172632 to 0b79779 Compare August 31, 2026 15:05
@elindseth
elindseth deployed to milo_pr_merge August 31, 2026 15:23 — with GitHub Actions Active
@milo-pr-merge
milo-pr-merge Bot merged commit d1f1b78 into stage Aug 31, 2026
18 checks passed
@milo-pr-merge
milo-pr-merge Bot deleted the intl1207-content-toggle branch August 31, 2026 15:23
@github-actions github-actions Bot mentioned this pull request Aug 31, 2026
Merged
joaquinrivero added a commit that referenced this pull request Aug 31, 2026
@joaquinrivero
Merge remote-tracking branch 'origin/stage' into MWPW-202435
feb9255 
* origin/stage: (33 commits)
  INTL1207 - Add content-toggle block for A/B test campaign (#6451)
  Add a guard in decorateAutoBlock for merch links (#6567)
  [MWPW-204859]  - Apply forced-reflow fix to brand-concierge floating (#6510)
  [MWPW-204698] Remove manifest overline (#6496)
  [Milo][Martech] Remove performance consent check from analytics event sending (#6491)
  MWPW-203941: Update authoring pattern for bc marquee (#6490)
  MWPW-204795 [MEP] Remove RainFocus registration-data (event-id) path (#6483)
  [MWPW-204301] [Lingo] MEP replace/remove on mep-lingo fragments + regional replacement resolution (#6474)
  MWPW-202286 Separate mas field from merch card autoblock (#6463)
  [MWPW-203054] [MWPW-203055] - Additional Manifest and Page Summary fields. (#6446)
  MWPW-200965: Port email-collection block to C2 (#6441)
  [MWPW-205693]: Adding rtl change for languageselector (#6581)
  [MWPW-204596] Validate the fedsbranch query parameter in C2 global-navigation (#6497)
  [MWPW-199609] Harden sanitizeHtml URL scheme allowlist (#6475)
  MWPW-204984: Revert eager IMS load (#6511) (#6549)
  MWPW-204984
  [MWPW-204913]: C2 persistent cart (#6522)
  fix for mc autoblock
  MWPW-204875: eagerly load ims
  up to date with main
  ...

# Conflicts:
#	libs/blocks/merch-card-autoblock/merch-card-autoblock.js
#	libs/blocks/merch/merch.js
#	test/blocks/merch-card-autoblock/merch-card-autoblock.test.js
joaquinrivero added a commit that referenced this pull request Aug 31, 2026
@joaquinrivero
Merge remote-tracking branch 'origin/stage' into MWPW-202435
28cd2ab 
* origin/stage: (33 commits)
  INTL1207 - Add content-toggle block for A/B test campaign (#6451)
  Add a guard in decorateAutoBlock for merch links (#6567)
  [MWPW-204859]  - Apply forced-reflow fix to brand-concierge floating (#6510)
  [MWPW-204698] Remove manifest overline (#6496)
  [Milo][Martech] Remove performance consent check from analytics event sending (#6491)
  MWPW-203941: Update authoring pattern for bc marquee (#6490)
  MWPW-204795 [MEP] Remove RainFocus registration-data (event-id) path (#6483)
  [MWPW-204301] [Lingo] MEP replace/remove on mep-lingo fragments + regional replacement resolution (#6474)
  MWPW-202286 Separate mas field from merch card autoblock (#6463)
  [MWPW-203054] [MWPW-203055] - Additional Manifest and Page Summary fields. (#6446)
  MWPW-200965: Port email-collection block to C2 (#6441)
  [MWPW-205693]: Adding rtl change for languageselector (#6581)
  [MWPW-204596] Validate the fedsbranch query parameter in C2 global-navigation (#6497)
  [MWPW-199609] Harden sanitizeHtml URL scheme allowlist (#6475)
  MWPW-204984: Revert eager IMS load (#6511) (#6549)
  MWPW-204984
  [MWPW-204913]: C2 persistent cart (#6522)
  fix for mc autoblock
  MWPW-204875: eagerly load ims
  up to date with main
  ...

# Conflicts:
#	libs/blocks/merch-card-autoblock/merch-card-autoblock.js
#	libs/blocks/merch/merch.js
#	test/blocks/merch-card-autoblock/merch-card-autoblock.test.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpratt2 jpratt2 jpratt2 approved these changes
@seprakas seprakas seprakas approved these changes

Assignees

No one assigned

Labels

Ready for Stage zero-impact

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elindseth @jpratt2 @seprakas