Skip to content

MWPW-202286 Separate mas field from merch card autoblock - #6463

Merged
milo-pr-merge[bot] merged 10 commits into
stagefrom
MWPW-202286
Aug 30, 2026
Merged

MWPW-202286 Separate mas field from merch card autoblock#6463
milo-pr-merge[bot] merged 10 commits into
stagefrom
MWPW-202286

Conversation

@TsayAdobe

@TsayAdobe TsayAdobe commented Aug 12, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor
  • This PR separates mas-field rendering from the merch-card-autoblock path. When a marquee (or any LCP block) is authored with an inline field, it now only needs the lightweight commerce.js from MAS libs to resolve that field — merch-card.js, lit-all.min.js, and merch-quantity-select.js are no longer required for the initial render and load after LCP.
  • This is a performance-only change; page behavior is unchanged, with no functional impact.
  • Note: this PR depends on a companion change in MAS. Release should be coordinated between the two.

Resolves: MWPW-202286

Test URLs:

loadingchart * On stage, odinpreview calls happen before LCP — these don't occur on production, so real-world performance will be better than what's observed on stage.
GNav Test URLs

Gnav + Footer + Region Picker modal:

Thin Gnav + ThinFooter + Region Picker dropup:

Localnav + Promo:

Sticky Branch Banner:

Inline Branch Banner:

Blog

RTL Locale

@TsayAdobe
TsayAdobe requested a review from a team as a code owner August 12, 2026 15:35
@aem-code-sync

aem-code-sync Bot commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@TsayAdobe TsayAdobe mentioned this pull request Aug 12, 2026
Closed
yesil
yesil requested changes Aug 14, 2026
View reviewed changes
Comment thread libs/blocks/merch/mas-field.js Outdated
@Roycethan
Roycethan self-requested a review August 17, 2026 20:23
@TsayAdobe
TsayAdobe requested a review from yesil August 17, 2026 22:27
@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

yesil
yesil reviewed Aug 18, 2026
View reviewed changes
Comment thread libs/blocks/merch/merch.js Outdated
Comment thread libs/blocks/merch/merch.js Outdated
@bozojovicic bozojovicic mentioned this pull request Aug 18, 2026
Merged
Roycethan
Roycethan requested changes Aug 18, 2026
View reviewed changes

@Roycethan Roycethan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TsayAdobe Its causing regression:
https://main--edu--adobecom.aem.live/education/students/acrobat?milolibs=mwpw-202286
Gnav with checkout CTAs not loading:

Image

Expected:
https://main--edu--adobecom.aem.live/education/students/acrobat

Image

@TsayAdobe
TsayAdobe requested a review from a team as a code owner August 19, 2026 01:09
@TsayAdobe
TsayAdobe requested a review from Roycethan August 19, 2026 01:56
@Roycethan

Roycethan commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

@TsayAdobe Its causing regression: https://main--edu--adobecom.aem.live/education/students/acrobat?milolibs=mwpw-202286 Gnav with checkout CTAs not loading:

Image Expected: https://main--edu--adobecom.aem.live/education/students/acrobat Image

Fixed...

@Roycethan Roycethan added the verified PR has been E2E tested by a reviewer label Aug 19, 2026
@Roycethan
Roycethan deployed to milo_pr_merge August 19, 2026 21:50 — with GitHub Actions Active
@Roycethan
Roycethan deployed to milo_pr_merge August 19, 2026 22:35 — with GitHub Actions Active
@yesil yesil mentioned this pull request Aug 28, 2026
Open
@milo-pr-merge
milo-pr-merge Bot merged commit 69a0921 into stage Aug 30, 2026
21 of 24 checks passed
@milo-pr-merge
milo-pr-merge Bot deleted the MWPW-202286 branch August 30, 2026 09:43
@milo-pr-merge milo-pr-merge Bot mentioned this pull request Aug 30, 2026
Merged
@mokimo mokimo mentioned this pull request Aug 31, 2026
Merged
joaquinrivero added a commit that referenced this pull request Aug 31, 2026
@joaquinrivero
Merge remote-tracking branch 'origin/stage' into MWPW-202435
feb9255 
* origin/stage: (33 commits)
  INTL1207 - Add content-toggle block for A/B test campaign (#6451)
  Add a guard in decorateAutoBlock for merch links (#6567)
  [MWPW-204859]  - Apply forced-reflow fix to brand-concierge floating (#6510)
  [MWPW-204698] Remove manifest overline (#6496)
  [Milo][Martech] Remove performance consent check from analytics event sending (#6491)
  MWPW-203941: Update authoring pattern for bc marquee (#6490)
  MWPW-204795 [MEP] Remove RainFocus registration-data (event-id) path (#6483)
  [MWPW-204301] [Lingo] MEP replace/remove on mep-lingo fragments + regional replacement resolution (#6474)
  MWPW-202286 Separate mas field from merch card autoblock (#6463)
  [MWPW-203054] [MWPW-203055] - Additional Manifest and Page Summary fields. (#6446)
  MWPW-200965: Port email-collection block to C2 (#6441)
  [MWPW-205693]: Adding rtl change for languageselector (#6581)
  [MWPW-204596] Validate the fedsbranch query parameter in C2 global-navigation (#6497)
  [MWPW-199609] Harden sanitizeHtml URL scheme allowlist (#6475)
  MWPW-204984: Revert eager IMS load (#6511) (#6549)
  MWPW-204984
  [MWPW-204913]: C2 persistent cart (#6522)
  fix for mc autoblock
  MWPW-204875: eagerly load ims
  up to date with main
  ...

# Conflicts:
#	libs/blocks/merch-card-autoblock/merch-card-autoblock.js
#	libs/blocks/merch/merch.js
#	test/blocks/merch-card-autoblock/merch-card-autoblock.test.js
joaquinrivero added a commit that referenced this pull request Aug 31, 2026
@joaquinrivero
Merge remote-tracking branch 'origin/stage' into MWPW-202435
28cd2ab 
* origin/stage: (33 commits)
  INTL1207 - Add content-toggle block for A/B test campaign (#6451)
  Add a guard in decorateAutoBlock for merch links (#6567)
  [MWPW-204859]  - Apply forced-reflow fix to brand-concierge floating (#6510)
  [MWPW-204698] Remove manifest overline (#6496)
  [Milo][Martech] Remove performance consent check from analytics event sending (#6491)
  MWPW-203941: Update authoring pattern for bc marquee (#6490)
  MWPW-204795 [MEP] Remove RainFocus registration-data (event-id) path (#6483)
  [MWPW-204301] [Lingo] MEP replace/remove on mep-lingo fragments + regional replacement resolution (#6474)
  MWPW-202286 Separate mas field from merch card autoblock (#6463)
  [MWPW-203054] [MWPW-203055] - Additional Manifest and Page Summary fields. (#6446)
  MWPW-200965: Port email-collection block to C2 (#6441)
  [MWPW-205693]: Adding rtl change for languageselector (#6581)
  [MWPW-204596] Validate the fedsbranch query parameter in C2 global-navigation (#6497)
  [MWPW-199609] Harden sanitizeHtml URL scheme allowlist (#6475)
  MWPW-204984: Revert eager IMS load (#6511) (#6549)
  MWPW-204984
  [MWPW-204913]: C2 persistent cart (#6522)
  fix for mc autoblock
  MWPW-204875: eagerly load ims
  up to date with main
  ...

# Conflicts:
#	libs/blocks/merch-card-autoblock/merch-card-autoblock.js
#	libs/blocks/merch/merch.js
#	test/blocks/merch-card-autoblock/merch-card-autoblock.test.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yesil yesil yesil approved these changes
@Blainegunn Blainegunn Blainegunn approved these changes
@Roycethan Roycethan Roycethan approved these changes
@joaquinrivero joaquinrivero Awaiting requested review from joaquinrivero
@Axelcureno Axelcureno Awaiting requested review from Axelcureno

Assignees

No one assigned

Labels

Ready for Stage verified PR has been E2E tested by a reviewer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TsayAdobe @Roycethan @yesil @Blainegunn