Skip to content

MWPW-204984: Revert eager IMS load (#6511) - #6549

Merged
vhargrave merged 4 commits into
stagefrom
MWPW-204984
Aug 25, 2026
Merged

MWPW-204984: Revert eager IMS load (#6511)#6549
vhargrave merged 4 commits into
stagefrom
MWPW-204984

Conversation

@yesil

@yesil yesil commented Aug 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reverts the eager IMS load and keeps the Lingo IMS Country Code feature intact.

  • Revert #6511 — MWPW-204875: eagerly load ims

Resolves: MWPW-204984

Test URLs:

@yesil
yesil requested a review from a team as a code owner August 24, 2026 16:58
@aem-code-sync

aem-code-sync Bot commented Aug 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

Roycethan
Roycethan requested changes Aug 24, 2026
View reviewed changes

@Roycethan Roycethan left a comment •
edited by yesil
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yesil I see pricing in US$ on this branch when signed in with CA account:
https://www.stage.adobe.com/products/photoshop.html?milolibs=mwpw-204984--milo--adobecom&maslibs=mwpw-204984--mas--adobecom&mas.preview=off

Image

compared to
https://www.stage.adobe.com/products/photoshop.html?mas.preview=off
where its in CAD$

Image

@Roycethan Roycethan mentioned this pull request Aug 24, 2026
Merged
6 tasks
@yesil yesil changed the title MWPW-204984: Revert IMS Country Code (#6261) and eager IMS load (#6511) MWPW-204984: Revert eager IMS load (#6511) Aug 25, 2026
@yesil
yesil requested a review from Roycethan August 25, 2026 09:51
@yesil

yesil commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

@Roycethan I addressed your findings in both PRs.

Blainegunn
Blainegunn reviewed Aug 25, 2026
View reviewed changes

@Blainegunn Blainegunn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is it!
Thank you @yesil

@Roycethan Roycethan added verified PR has been E2E tested by a reviewer Ready for Stage labels Aug 25, 2026
@Roycethan
Roycethan deployed to milo_pr_merge August 25, 2026 16:05 — with GitHub Actions Active
@Roycethan
Roycethan deployed to milo_pr_merge August 25, 2026 16:05 — with GitHub Actions Active
@vhargrave
vhargrave merged commit da98495 into stage Aug 25, 2026
22 checks passed
@vhargrave
vhargrave deleted the MWPW-204984 branch August 25, 2026 17:25
@milo-pr-merge milo-pr-merge Bot mentioned this pull request Aug 30, 2026
Merged
@mokimo mokimo mentioned this pull request Aug 31, 2026
Merged
joaquinrivero added a commit that referenced this pull request Aug 31, 2026
@joaquinrivero
Merge remote-tracking branch 'origin/stage' into MWPW-202435
feb9255 
* origin/stage: (33 commits)
  INTL1207 - Add content-toggle block for A/B test campaign (#6451)
  Add a guard in decorateAutoBlock for merch links (#6567)
  [MWPW-204859]  - Apply forced-reflow fix to brand-concierge floating (#6510)
  [MWPW-204698] Remove manifest overline (#6496)
  [Milo][Martech] Remove performance consent check from analytics event sending (#6491)
  MWPW-203941: Update authoring pattern for bc marquee (#6490)
  MWPW-204795 [MEP] Remove RainFocus registration-data (event-id) path (#6483)
  [MWPW-204301] [Lingo] MEP replace/remove on mep-lingo fragments + regional replacement resolution (#6474)
  MWPW-202286 Separate mas field from merch card autoblock (#6463)
  [MWPW-203054] [MWPW-203055] - Additional Manifest and Page Summary fields. (#6446)
  MWPW-200965: Port email-collection block to C2 (#6441)
  [MWPW-205693]: Adding rtl change for languageselector (#6581)
  [MWPW-204596] Validate the fedsbranch query parameter in C2 global-navigation (#6497)
  [MWPW-199609] Harden sanitizeHtml URL scheme allowlist (#6475)
  MWPW-204984: Revert eager IMS load (#6511) (#6549)
  MWPW-204984
  [MWPW-204913]: C2 persistent cart (#6522)
  fix for mc autoblock
  MWPW-204875: eagerly load ims
  up to date with main
  ...

# Conflicts:
#	libs/blocks/merch-card-autoblock/merch-card-autoblock.js
#	libs/blocks/merch/merch.js
#	test/blocks/merch-card-autoblock/merch-card-autoblock.test.js
joaquinrivero added a commit that referenced this pull request Aug 31, 2026
@joaquinrivero
Merge remote-tracking branch 'origin/stage' into MWPW-202435
28cd2ab 
* origin/stage: (33 commits)
  INTL1207 - Add content-toggle block for A/B test campaign (#6451)
  Add a guard in decorateAutoBlock for merch links (#6567)
  [MWPW-204859]  - Apply forced-reflow fix to brand-concierge floating (#6510)
  [MWPW-204698] Remove manifest overline (#6496)
  [Milo][Martech] Remove performance consent check from analytics event sending (#6491)
  MWPW-203941: Update authoring pattern for bc marquee (#6490)
  MWPW-204795 [MEP] Remove RainFocus registration-data (event-id) path (#6483)
  [MWPW-204301] [Lingo] MEP replace/remove on mep-lingo fragments + regional replacement resolution (#6474)
  MWPW-202286 Separate mas field from merch card autoblock (#6463)
  [MWPW-203054] [MWPW-203055] - Additional Manifest and Page Summary fields. (#6446)
  MWPW-200965: Port email-collection block to C2 (#6441)
  [MWPW-205693]: Adding rtl change for languageselector (#6581)
  [MWPW-204596] Validate the fedsbranch query parameter in C2 global-navigation (#6497)
  [MWPW-199609] Harden sanitizeHtml URL scheme allowlist (#6475)
  MWPW-204984: Revert eager IMS load (#6511) (#6549)
  MWPW-204984
  [MWPW-204913]: C2 persistent cart (#6522)
  fix for mc autoblock
  MWPW-204875: eagerly load ims
  up to date with main
  ...

# Conflicts:
#	libs/blocks/merch-card-autoblock/merch-card-autoblock.js
#	libs/blocks/merch/merch.js
#	test/blocks/merch-card-autoblock/merch-card-autoblock.test.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Blainegunn Blainegunn Blainegunn approved these changes
@TsayAdobe TsayAdobe TsayAdobe approved these changes
@Roycethan Roycethan Roycethan approved these changes
@sukamat sukamat sukamat approved these changes
@vhargrave vhargrave vhargrave approved these changes

Assignees

No one assigned

Labels

Ready for Stage verified PR has been E2E tested by a reviewer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yesil @Blainegunn @TsayAdobe @Roycethan @sukamat @vhargrave