Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Upload.Dragger): move className and Style pass to ant-upload-drag #19985

Closed
wants to merge 64 commits into from

Conversation

yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Nov 28, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

close #19945

📝 Changelog

Language Changelog
🇺🇸 English move className and Style pass ant-upload-drag
🇨🇳 Chinese className和style样式统一赋予drag 的 div

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

zombieJ and others added 30 commits November 11, 2019 11:52
* fix: fix upload error style

* feat: demo

* feat: test

* fix: tooltip
* feat: code add stackblitz

* fix: style

* Update site/theme/static/demo.less

Co-Authored-By: 偏右 <afc163@gmail.com>
* fix: update Select type interface

* format: Select type interface
* Update NL-nl locales

* Fix for tests
* fix footer fiexd

* fix test
* introduce codesandbox ci

* set skipLibCheck temporarilly

* remove packtracker temporarilly

* debug env
* docs: 3.25.2 changelog

* fix link
* Update sk_SK locales

### 🤔 This is a ...

- [ ] New feature
- [x] Bug fix
- [ ] Site / document update
- [ ] Component style update
- [ ] TypeScript definition update
- [ ] Refactoring
- [ ] Code style optimization
- [ ] Test Case
- [ ] Branch merge
- [ ] Other (about what?)

### 🔗 Related issue link

sk_SK locales are missing some translations.

* update snapshot
* Update link to latest ColumnProps

* update CN docs
mbotnari and others added 17 commits November 24, 2019 19:10
* Update custom-filter-panel.md

In order to decrease the confusion during search created by highlighted text in all the columns, the proposal is to highlight searched text in the searched column exclusively.

* chore(Table): Update demo.test.js.snap

Snapshot update according to update in components/table/demo/custom-filter-panel.md

* chore(Table): Update custom-filter-panel.md demo

Missing trailing comma comma-dangle
* ci: fix cannot create directory with mkdir

* chore: retrigger
* 为Form新增如何在函数组件中使用的例子

* 在Form FAQ中增加在函数组件中怎么正确拿到Form实例的说明

* 更新英文文档

* 按照comment修改

* 更新英文标题

* 修改英文文档FAQ的标题

* 修改英文文档里的大小写问题

* 按照豆酱的comments进行修改

* 按照comments进行修改
@yoyo837 yoyo837 changed the title move className and Style pass ant-upload-drag move className and Style pass to ant-upload-drag Nov 28, 2019
@netlify
Copy link

netlify bot commented Nov 28, 2019

Deploy preview for ant-design ready!

Built with commit f0fa54b

https://deploy-preview-19985--ant-design.netlify.com

@yoyo837 yoyo837 changed the title move className and Style pass to ant-upload-drag fix(Upload.Dragger): move className and Style pass to ant-upload-drag Nov 28, 2019
@auto-add-label auto-add-label bot added the bug label Nov 28, 2019
@afc163
Copy link
Member

afc163 commented Nov 28, 2019

feature branch will be nicer

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f0fa54b:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Nov 28, 2019

Codecov Report

Merging #19985 into feature will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #19985      +/-   ##
===========================================
- Coverage    97.81%    97.8%   -0.01%     
===========================================
  Files          286      284       -2     
  Lines         7722     7707      -15     
  Branches      2174     2155      -19     
===========================================
- Hits          7553     7538      -15     
  Misses         169      169
Impacted Files Coverage Δ
components/slider/index.tsx 89.18% <ø> (ø) ⬆️
components/tooltip/index.tsx 96.62% <ø> (ø) ⬆️
components/message/index.tsx 94.2% <100%> (-0.09%) ⬇️
components/upload/Upload.tsx 99.23% <100%> (ø) ⬆️
components/spin/index.tsx 95.31% <100%> (+0.15%) ⬆️
components/upload/UploadList.tsx 100% <100%> (ø) ⬆️
components/notification/index.tsx 96.15% <0%> (-0.24%) ⬇️
components/table/Table.tsx 99.48% <0%> (-0.01%) ⬇️
components/date-picker/locale/mk_MK.tsx
components/time-picker/locale/mk_MK.tsx

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 965bc58...f0fa54b. Read the comment docs.

@yoyo837 yoyo837 changed the base branch from master to feature November 28, 2019 08:01
@yoyo837 yoyo837 closed this Nov 28, 2019
@yoyo837 yoyo837 deleted the style-pass-wrapper branch November 28, 2019 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.