Skip to content

[AIRFLOW-7044] Add host_key option to SSH connection extras#7714

Closed
aaronfowles wants to merge 97 commits intoapache:masterfrom
aaronfowles:AIRFLOW-7044_host_key
Closed

[AIRFLOW-7044] Add host_key option to SSH connection extras#7714
aaronfowles wants to merge 97 commits intoapache:masterfrom
aaronfowles:AIRFLOW-7044_host_key

Conversation

@aaronfowles
Copy link

@aaronfowles aaronfowles commented Mar 13, 2020

This PR adds a new option in the SSH connection extras where you can specify base64 ssh-rsa public key of a host. The SSHHook constructor will then add this key to ~/.ssh/known_hosts if not present.

NB - this is my first time submitting to this project.

Issue link: AIRFLOW-7044

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

aaron.fowles and others added 24 commits March 13, 2020 14:19
* DAG serialization improvement: the DAG's source code is now stored in the dag_code table and is queried from here when the Code view is opened for the DAG. The webserver no longer needs access to the dags folder in the shared filesystem.
…7678)

Each stage of the CI tests needs to pull our `ci` image. By removing
java from it we can save 1-2minutes from each test stage. This is part
of that work.
The original fix from the commit
b4215f6 

was wrong. It converted to utc initially but then make_naive
had used TIMEZONE and converted it to the lcoal timezone rather
than UTC.
Pausing and unpausing dags in the dags view is asynchronous, and there
is currently no indication to the user if the operation fails. This
patch updates the paused input and highlights it in red when pausing or
unpausing fails.
@codecov-io
Copy link

codecov-io commented Mar 16, 2020

Codecov Report

Merging #7714 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7714   +/-   ##
=======================================
  Coverage   86.17%   86.17%           
=======================================
  Files         915      915           
  Lines       44196    44196           
=======================================
  Hits        38085    38085           
  Misses       6111     6111           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ee4be8...9ee4be8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.