Skip to content

Conversation

@NestorCao
Copy link

What is the purpose of the change

(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)

Brief change log

(for example:)

  • The TaskInfo is stored in the blob store on job creation time as a persistent artifact
  • Deployments RPC transmits only the blob storage reference
  • TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (100MB)
  • Extended integration test for recovery after master (JobManager) failure
  • Added test that validates that TaskInfo is transferred only once across recoveries
  • Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

rmetzger and others added 30 commits June 25, 2021 15:58
This commit hardens the RunnablesTest.testExecutorService_uncaughtExceptionHandler to not rely
on timeouts to check whether the uncaught exception handler was called.

This closes #16262.
The query doesn't impose any ordering and a reorder may happen as is.
Also make flink-sql-connector-kinesis use the Guava library
coming transitively from the connector-kinesis dependency.
…mon dependencies.

Connectors get shaded into the user jar and as such should contain no unnecessary dependencies to flink. However, connector-base is exposing `flink-core` which then by default gets shaded into the user jar. Except for 6MB of extra size, the dependency also causes class loading issues, when `classloader.parent-first-patterns` does not include `o.a.f`.
OperatorChain creates the outputs and owns them, so that it should also close them. Specific operators should not close the outputs.

Also, ChainingOutput should never close the chained operator; it's not owning the operator.
…on until checkpoint confirmed

Currently, the test job makes too many attempts with little progress and
eventually times out.
Too many attempts are made because each checkpoint can be failed by any
FailingMapper that reaches its randomly chosen threshold. And if some
subtask becomes back-pressured then any of three others will likely fail
the checkpoint, reverting the progress.
This change makes sources to pause for the checkpoint confirmation; and
fixes static fields so that it runs more reliably in a loop locally.
…e job is canceling or failing

Cancel all pending requests of a canceled/failed execution version, or the requests may be fulfilled with a slot released by a previously fulfilled task and then released immediately, which is executed recursively and may cause StackOverflowException when the scale is too large.
…ouldn't merge properties for alter DB operation
…rs semantics change in MiniClusterJobClient

FLINK-18685 changed the semantics of the MiniClusterJobClient. This commit updates the 1.13 release notes
accordingly.

This closes #16256.
HuangXingBo and others added 24 commits September 17, 2021 19:15
…t on checkpoint and disable it if group ID is not specified

(cherry picked from commit ca8bff2)
…ace for validating offset initializer in KafkaSourceBuilder

(cherry picked from commit 2da73ed)
… lead to full failover, not JobManager failure.

Instead of letting exceptions during the creation of the Source Enumerator bubble up (and utimately fail
the JobManager / Scheduler creation), we now catch those exceptions and trigger a full (global) failover
for that case.
…sm is higher than partitions in KafkaSource

Before this commit the enumerator signalled the leftover source readers
without a partition to finish. This caused that checkpointing was not
possible anymore because it is only supported if all tasks are running
or FLIP-147 is enabled.

This closes #17330
A fatal error will be thrown if the retry fails.

This closes #17336.
This commit hardens the common_ha.sh#ha_tm_watchdog function by always starting
the expected number of TaskManagers. This will ensure that the e2e tests that are
using this function also pass if a TaskManager dies accidentally.
…ter_datastream.sh and test_ha_datastream.sh

This commit reduces the number of JM kills in test_ha_per_job_cluster_datastream.sh and test_ha_datastream.sh because on
CI killing the JM 3 times can take more than the current timeout (15 minutes) (2 minutes per successful checkpoint, 8
successful checkpoints required to pass).

This closes #17139.
State that only the MemoryStateBackend does not support local recovery.
…tionScan to Correlate

This closes #16192

(cherry picked from commit f83e603)
…erializing records from testcsv

This closes #17308

(cherry picked from commit 4d69f7f)
…FO configured. (#17417)

* FLINK-24431 Stop consumer deregistration when EAGER EFO configured.

* FLINK-24431 Verify criteria for stream deregistration in unit tests.

* FLINK-24431 Update documentation to reflect new EAGER EFO strategy changes.

* FLINK-24431 Remove Java 11 language feature usage in consumer unit test.

* FLINK-24431 Untranslated zh documentation updated to match kinesis documentation changes.
@NestorCao
Copy link
Author

拉取apache flink 1.14

@NestorCao
Copy link
Author

pull apache flink release-1.14

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 14, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit a58dd48 (Thu Oct 14 09:22:47 UTC 2021)

Warnings:

  • 33 pom.xml files were touched: Check for build and licensing issues.
  • Invalid pull request title: No valid Jira ID provided

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@zentol zentol closed this Oct 14, 2021
@NestorCao NestorCao deleted the release-1.14 branch October 15, 2021 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.