SAI-4486: force update collection if is missing by noblepaul · Pull Request #1776 · apache/solr

noblepaul · 2023-07-12T07:57:02Z

No description provided.

…pache#1239) Co-authored-by: Nazerke Seidan <nseidan@salesforce.com> Co-authored-by: Kevin Risden <krisden@apache.org>

(cherry picked from commit 28d6b01)

(cherry picked from commit bb94e78)

)

…se to fix (#64)

* Changed indent size for state.json file from 2 to 0 * updated test. Set default indent to 0 * Update test to remove log message. Co-authored-by: Hitesh Khamesra <hiteshk25@yahoo.com> Co-authored-by: hitesh <hitesh@fullstory.com>

…files (apache#1284)

Prior to this commit, the "disable.v2.api" flag covered some aspects of request routing, but wasn't consulted during requestHandler parsing/bootstrapping or CoreContainer initialization. This commit creates a small utility method in V2ApiUtils to simplify the enabled/disabled check, and uses it in a few additional places to make sure Solr isn't doing any unnecessary work when v2 has explicitly been turned off.

Co-authored-by: Eric Pugh <epugh@opensourceconnections.com>

…e#1177) Co-authored-by: Jan Høydahl <janhoy@users.noreply.github.com>

… from CONTRIBUTING.md

…apache id) (apache#1290) (cherry picked from commit 1d65ab6)

…pache#1291) (cherry picked from commit 8b24b6b)

(cherry picked from commit ac32afd)

…ate.json (apache#1293)

* Allowing for distinct Solr SSL port so that http and https can exist side by side * Adding redirect on http call * Attempting to exclude metrics and health endpoints from SSL * Attempting to exclude metrics and health endpoints from SSL * Adding ability to set a secure port as well as a host port and using the secure port of the urlscheme is https * Fixing string equality * Handling cases where only https is used so secure port isn't set differently * Adding secureHostPort to solr xml config parsing * Fixing break

* For select/get query, adjust the description in PrometheusMetricsServlet to describe the new definition of distributed/local metrics for udpate request, add a new [local] metrics so it's consistent with 8.x * Fixed unit test case

…n" (#97) * Revert "Avoid unnecessary map creation while serializing DocCollection" This reverts commit 2ac7ed2. SOLR-16753: SplitShardWithNodeRoleTest.testSolrClusterWithNodeRoleWithPull failures * minor fix --------- Co-authored-by: Noble Paul <noble.paul@gmail.com>

…ly do not want that returned unless specifically added as an fl param (#98) * Ignoring _version_ field for glob patterns on export since we typically do not want that returned unless specifically added as an fl param * Using CommonParams property and adding test * Tidying code * Fixing message for test

* Fixed metrics for update requests * Fixed unit test case

…yField (#100) (cherry picked from commit 7926d9e)

(cherry picked from commit 21f8b09)

* Adding Breakpoint injection to CommonTestInjection * ./gradlew tidy * Fixed javadoc * Fixed race condition for PRS collection on deletion Added unit test case in ZkStateReaderTest#testDeletePrsCollection * ./gradlew tidy * Separate the exception handling of NoNodeException and PrsZkNodeNotFoundException as their conditions/handling are quite different. * Fixed Execution failed for task ':solr:solrj-zookeeper:validateLogCalls'. * ./gradlew tidy * Fixed validateLogCalls

* Fixed breakpoint cleanup * ./gradlew tidy

* Ensuring coordinator role can work when enabled on mulitple nodes * Improving logic for creating coordinator node cores * Using constant for coordinator collection

* Updating SelectStream to handle glob patterns * Tidying code * Ensuring initialization of glob patterns list in constructor

Co-authored-by: Michael Gibney <michael@michaelgibney.net> (cherry picked from commit 658889c)

* Fixed missing rid in SearchHandler log message * ./gradlew tidy

…utImpl) (#111)

…collection is deleted (apache#1752)

…pache#1753)

…r Node upon collection deletion (apache#1754) * CoordinatorHttpSolrCall should remove collection from mapping upon collection deletion * Updated CHANGES.txt --------- Co-authored-by: Justin Sweeney <justinsweeney@fullstory.com>

ports changes from: fullstorydev/lucene-solr#204 (60964ece8abc1e7e838b9a8f1e54ff7f4505d91d) fullstorydev/lucene-solr#207 (ee264220729490da81916af8c2ae23c5e4e52718) fullstorydev/lucene-solr#208 (20b2b694c223723c6e80c2344b401772c67221ce) fullstorydev/lucene-solr#209 (8835c4d0b4d90de90559c380dab8e51a0ee895a6) along with updates to compile against branch_9x (cherry picked from commit 0df9c08)

sonatype-lift · 2023-07-12T09:02:02Z

dev-tools/scripts/smokeTestRelease.py

+  print('      Running techproducts example on port 8983 from %s' % binaryDistPath)
  try:
    if not cygwin:
      runExampleStatus = subprocess.call(['bin/solr','-e','techproducts'])


B607: Starting a process with a partial executable path

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-07-12T09:02:04Z

dev-tools/scripts/smokeTestRelease.py

+  print('      Running techproducts example on port 8983 from %s' % binaryDistPath)
  try:
    if not cygwin:
      runExampleStatus = subprocess.call(['bin/solr','-e','techproducts'])


B603: subprocess call - check for execution of untrusted input.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-07-12T09:02:07Z

dev-tools/scripts/buildAndPushRelease.py

+  rev = open('%s/solr/distribution/build/release/.gitrev' % root, encoding='UTF-8').read()

+  dir = 'solr-%s-RC%d-rev-%s' % (version, rcNum, rev)
+  os.makedirs('%s/%s/solr' % (localDir, dir))


E111: indentation is not a multiple of 4

❗❗ 4 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding

File Path Line Number

dev-tools/scripts/buildAndPushRelease.py 230

dev-tools/scripts/smokeTestRelease.py 543

dev-tools/scripts/smokeTestRelease.py 739

dev-tools/scripts/smokeTestRelease.py 1125

Visit the Lift Web Console to find more details in your report.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-07-12T09:02:09Z

dev-tools/scripts/smokeTestRelease.py

+  print('      Running techproducts example on port 8983 from %s' % binaryDistPath)
  try:
    if not cygwin:
      runExampleStatus = subprocess.call(['bin/solr','-e','techproducts'])


E231: missing whitespace after ','

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-07-12T09:02:12Z

dev-tools/scripts/smokeTestRelease.py

+  print('      Running techproducts example on port 8983 from %s' % binaryDistPath)
  try:
    if not cygwin:
      runExampleStatus = subprocess.call(['bin/solr','-e','techproducts'])


E231: missing whitespace after ','

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

NazerkeBS and others added 30 commits January 10, 2023 00:47

SOLR-15787: Fix FileSystemConfigSetService test failure on Windows (a…

91a2e84

…pache#1239) Co-authored-by: Nazerke Seidan <nseidan@salesforce.com> Co-authored-by: Kevin Risden <krisden@apache.org>

SOLR-16480: Add overridable allow-list for ConfigSet file types

7d20587

(cherry picked from commit 28d6b01)

SOLR-16480: Fix major changes section

330400b

(cherry picked from commit bb94e78)

SOLR-16613: CryptoKeys should handle RSA padding for OpenJ9 (apache#1279

f9b486c

)

SOLR-16457: Use pwd -P (apache#1282)

ebf6126

SOLR-13243: Correct initial capacity of ops (apache#1232)

953ac35

Null check added in package loader. It was just throwing an NPE

e0cf4e3

SOLR-16617: DocSetBuilder should use DocSetUtil#smallSetSize (apache#…

d143545

…1285)

CI times out on large test suite; make CI logging slightly more verbo…

14d6953

…se to fix (#64)

usage of package loaded class in the wrong tests

92dd93d

test case added for coordinator role

ec9b152

test files in wrong dir

4944ffb

SOLR-16616: JWTAuthPlugin: Read trusted X509 certificates from multi …

e604e83

…files (apache#1284)

SOLR-14540: add an example clarifying the use case. (apache#499)

199477e

Co-authored-by: Eric Pugh <epugh@opensourceconnections.com>

SOLR-16544: Adding documentation for how to contribute to Solr (apach…

ab9bedf

…e#1177) Co-authored-by: Jan Høydahl <janhoy@users.noreply.github.com>

SOLR-16544 Linking to CONTRIBUTING.md from README.md, linking to Wiki…

f94c13d

… from CONTRIBUTING.md

releaseWizard: allow explicitly setting MANIFEST.MF userid (e.g., to …

be7ac89

…apache id) (apache#1290) (cherry picked from commit 1d65ab6)

buildAndPushRelease should optionally pause before assembleRelease (a…

47e19ff

…pache#1291) (cherry picked from commit 8b24b6b)

update releaseWizard.py to support offline gpg key (apache#1288)

86b357a

(cherry picked from commit ac32afd)

SOLR-16593 : Redundant fields are present in the replica object of st…

a8b9d04

…ate.json (apache#1293)

restore nightly test now that bug is fixed (apache#1265)

1ec2894

SOLR-16624: Remove Gradle Groovy version override (apache#1298)

cae9d0e

SOLR-16626: Upgrade to Netty 4.1.87.Final (apache#1300)

f6fcce7

SOLR-16625: Upgrade OWASP Dependency Check to 8.0.1 (apache#1299)

7c3e093

Correcting default minimalFreeDiskGB (apache#1292)

7abbf65

SOLR-16532 Further improvements to opentelemetry module (apache#1275)

5a39680

SOLR-14336 Warn users running old version of Solr (apache#1297)

e9c64c9

SOLR-15772 More visible security warnings in Admin UI (apache#1296)

a411386

noblepaul and others added 24 commits April 21, 2023 15:20

SOLR-16741: refactor Replia.State.toString() (apache#1549)

a4c64ab

Merge branch 'branch_9_2' into fs/branch_9_2

1d31967

SAI-4411: Missing query metrics since 9.x (#95)

3ef8c9c

* For select/get query, adjust the description in PrometheusMetricsServlet to describe the new definition of distributed/local metrics for udpate request, add a new [local] metrics so it's consistent with 8.x * Fixed unit test case

default SOLR_SSL_PORT to SOLR_PORT (#96)

d25b9cf

Fixed unit test case failure due to metric changes (#99)

945bc6b

* Fixed metrics for update requests * Fixed unit test case

add solr BloomStrField to facilitate config of ngram bloom filter pol…

858427b

…yField (#100) (cherry picked from commit 7926d9e)

uninvertible should be false on ngram field (double-negative) (#102)

1f53e0e

(cherry picked from commit 21f8b09)

SAI-4358: Fixed breakpoint cleanup in unit test case (#104)

3b48b4e

* Fixed breakpoint cleanup * ./gradlew tidy

Ensuring coordinator role can work when enabled on mulitple nodes (#109)

582d1a1

* Ensuring coordinator role can work when enabled on mulitple nodes * Improving logic for creating coordinator node cores * Using constant for coordinator collection

Updating SelectStream to handle glob patterns (#108)

9a685f8

* Updating SelectStream to handle glob patterns * Tidying code * Ensuring initialization of glob patterns list in constructor

Updating streaming parser to better handle nested quotes (#106)

4cdda85

Co-authored-by: Michael Gibney <michael@michaelgibney.net> (cherry picked from commit 658889c)

Fixed totalReplicas count for SimplePlacementPlugin (#110)

6c8531f

SAI-4528 : Missing rid in SearchHandler log (#113)

304c70f

* Fixed missing rid in SearchHandler log message * ./gradlew tidy

support dynamic ngram enable/disable (after pattern of SolrQueryTimeo…

b48f4e1

…utImpl) (#111)

SOLR-16860: Remove watch from ZkStateReader of Coordinator Node when …

5c93199

…collection is deleted (apache#1752)

SOLR-16861: Correct(override) MDC info for CoordinatorHttpSolrCall (a…

c6971f0

…pache#1753)

Fixing issue from cherry-pick of commits

818f1a5

Force update collection if missing

220b09d

noblepaul closed this Jul 12, 2023

sonatype-lift bot reviewed Jul 12, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

SAI-4486: force update collection if is missing #1776

SAI-4486: force update collection if is missing #1776
noblepaul wants to merge 1030 commits intoapache:mainfrom
cowpaths:noble/force_update_coll

noblepaul commented Jul 12, 2023

Uh oh!

sonatype-lift bot Jul 12, 2023

Uh oh!

sonatype-lift bot Jul 12, 2023

Uh oh!

sonatype-lift bot Jul 12, 2023

Uh oh!

sonatype-lift bot Jul 12, 2023

Uh oh!

sonatype-lift bot Jul 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Command	Usage
`@sonatype-lift ignore`	Leave out the above finding from this PR
`@sonatype-lift ignoreall`	Leave out all the existing findings from this PR
`@sonatype-lift exclude <file\|issue\|path\|tool>`	Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file

Comments

Conversation

noblepaul commented Jul 12, 2023

Uh oh!

sonatype-lift bot Jul 12, 2023

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jul 12, 2023

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jul 12, 2023

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jul 12, 2023

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jul 12, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants