-
Notifications
You must be signed in to change notification settings - Fork 38.1k
[0.13] release notes: remove bad advice to switch to blockmaxweight prematurely #8458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fill in the header, and move items to the appropriate part of the release notes structure.
df85463 Some 0.13 release notes about p2p changes (Pieter Wuille)
Do a few TODOs from bitcoin#7678: - Removal of internal miner - `mempool`/`NODE_BLOOM` interaction - Sorting of `getrawmempool` output
Github-Pull: bitcoin#8363 Rebased-From: 2c06bae
…D wallets 3b38a6a [Wallet] Ensure <0.13 clients can't open HD wallets (Jonas Schnelli)
ded0599 doc: Add a few items to release notes (Wladimir J. van der Laan)
The non-deterministic ordering produced by biplist ends up in the .DS_Store file that is included in the OSX dmg. Github-Pull: bitcoin#8373 Rebased-From: 3b3ce25
48b9208 Remove duplicated name in release notes (Johnson Lau)
Github-Pull: bitcoin#8378 Rebased-From: 6523fca
Don't start a line with a # unless you want that line to be a header.
ea91961 Fix formatting error (Chris Moore)
f891e34 fix typo: propagation relay -> delay (Jannes Faber)
52a4158 Add release notes for mining changes (Suhas Daftuar)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #8388 without the code changes. Since the only difference is adding numbers, there shouldn't be any noticable performance hit with blockmaxsize anyway.
(If we want to eliminate any difference just in case, another code change possibility would be to simply translate blockmaxsize to blockmaxweight when segwit is not enabled (ie, mainnet).)