[PM-6846] Added spaced card nubmer to the card view#3084
Closed
moalhaddar wants to merge 3881 commits intobitwarden:mainfrom
Closed
[PM-6846] Added spaced card nubmer to the card view#3084moalhaddar wants to merge 3881 commits intobitwarden:mainfrom
moalhaddar wants to merge 3881 commits intobitwarden:mainfrom
Conversation
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
… codebase (bitwarden#2558) * Adding locators for Environment, Hope, Login and Register pages * Adding Locators on LockPage * Adding Álison's suggestions
…s argon2id and the memory is higher than 48MB, to let the user know that unlocking might crash the extension (bitwarden#2560)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
Update F-Droid listing author name to `Bitwarden Inc`
…yboard when unlocking the extension. Also added way to prevent multiple executions of checking the password and logging exceptions. (bitwarden#2568)
…twarden#2564) * Adding AutomationIDs for Add/Edit Items page * Adding IDs to CustomFields * Adding Matt's suggestions * Adding newest suggestions
* Adding AutomationIDs on Generator pages * Adding missing spaces
* Adding IDs for Account Switching elements * Fixing Active/Inactive vault icon IDs
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
* Adding IDs for Cipher/Send search results * Adding missing spaces
…twarden#2574) * Adding AutomationIDs for LoginPasswordlessPag elements * Adding AutomationIDs for LoginPasswordlessRequest page elements * Fixing missing space
…rden#2576) * Adding IDs to CipherDetailsPage * Fixing extra spaces * Fixing extra space
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
* Adding IDS for Settings elements * Adding IDS for Settings elements
…rden#2586) * Refactoring locator strategy for Cipher Details page * Fixing extra spaces
* Adding IDs for Options and Folders pages * Fixing extra spaces
* PM-192 Refactor Forwarded email providers to use better patterns and code reuse. * PM-192 fix format
* Adding AutomationIDs for Send page elements * Fixing some spaces * Adding Matt's suggestion * Adding Fede's suggestion * Removing unnecesarry breaks
* Adding IDs for Vault Page sections * Removing extra spaces * Adding Matt's comments * Fixing Filters Id bug * Adding Fede's suggestions * Fixing Settings Ids issues * Fixing AutomationIds issues with RecyclerViews + implementing AutomationId helper class * Adding Fede's suggestion * Adding latest Fede's suggestions
* Fixing Toolbar locators * Adding Matt's suggestions
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
…en#2539)" (bitwarden#2597) This reverts commit 0288a66.
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
…oard Inline Autofill (bitwarden#2593)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
… opening Accessibility Settings (bitwarden#3047)
…bility (bitwarden#3051) * PM-6552 Removed several of the Window Workarounds for Android. Now always relying on the AndroidNavigationRedirectPage. AndroidNavigationRedirectPage now more resilient to failure and navigates to HomePage as fallback. * Update src/Core/Pages/AndroidNavigationRedirectPage.xaml.cs Co-authored-by: Federico Maccaroni <fedemkr@gmail.com> --------- Co-authored-by: Federico Maccaroni <fedemkr@gmail.com>
* PM-6539 Fix Autofill Extension TDE without MP updating PromptSSO to work in MAUI and also Generator view. WebAuthenticator copied with UIWindow gotten as it was in Xamarin forms to work. Also fix one NRE on state migration. * PM-6539 Remove unnecessary using
…3050) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…itwarden#3069) * Fix for Android 14 devices crashing when using the TileService. Also added fix for an "hidden" crash in accessibility autofill * Shared StartActivityAndCollapseFromTileService in AndroidHelpers * Update src/App/Platforms/Android/Utilities/AndroidHelpers.cs Co-authored-by: Federico Maccaroni <fedemkr@gmail.com> * Updated name of StartActivityAndCollapseWithIntent method name used by TileService --------- Co-authored-by: Federico Maccaroni <fedemkr@gmail.com>
…onsible for the Exception in WebAuthenticator (bitwarden#3071) * Added missing query intent for CustomTabs that might be responsible for the crashes in WebAuthenticator * minor formatting issue on AndroidManifest.xml * Fix formatting in AndroidManifest
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
|
|
|
Thank you for your contribution! We've added this to our internal Community PR board for review. |
bitwarden-bot
changed the title
|
A space every 4 digits is only correct for 16-digit card numbers. There are many card types that don't have 16 digits where having spacing every 4 digits is always incorrect, e.g. American Express, but there are also Visa and Maestro card number ranges which aren't 16 digits and those also have different spacing requirements. The other clients support this mostly properly (though unfortunately not for the edit view, where it's almost more important): https://github.com/bitwarden/clients/blob/9d342f61cb97e217756e04d1f6654642cb4768b2/libs/angular/src/pipes/credit-card-number.pipe.ts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
The card number in bitwarden mobile is not spaced in the mobile view. This pull request fixes the view such that the number is spaced in splits of 4.
Code changes
A new property in the CardView named SpacedNumber was added that adds a space in every 4 digits from the "CardView.Number"