Packaging Improvements #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gchenfc
approved these changes
Jul 8, 2020
Member
gchenfc
left a comment
gchenfc
left a comment
There was a problem hiding this comment.
Looks great! Detected python version and everything great on my (mac) machine, but it had some issues with
include_directories(${GTSAM_CYTHON_INSTALL_PATH})
include_directories(${GTSAM_EIGENCY_INSTALL_PATH})cython was empty, though that didn't seem to matter.
I had to hard code eigency as
include_directories("/Users/Gerry/GIT_REPOS/gtsam/build/install/cythonDebug/gtsam_eigency/")since otherwise it was using /Users/Gerry/GIT_REPOS/gtsam/build/install/cython/gtsam_eigency/. Presumably related to debug-mode.
But I think this has more to do with gtsam's cmake than rather than this project's config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I managed to find some issues lurking around which this PR fixes.
setup.pyflags to ensure correct packaging on install.TUTORIAL.md.