Add feature flag to allow enabling FileSystemAccess API. - #10785
Merged
Conversation
goodov
approved these changes
Nov 1, 2021
| } // namespace features | ||
| } // namespace blink | ||
|
|
||
|
|
| if (IsFileSystemAccessAPIEnabled()) { | ||
| auto result = | ||
| content::EvalJs(main_frame(), "typeof self.showOpenFilePicker"); | ||
| EXPECT_TRUE(*result.value.GetIfString() == "function") |
Member
There was a problem hiding this comment.
the dereference will crash if GetIfString returns nullptr, so we won't see DebugString() value at all. I'd go with:
ASSERT_TRUE(result.value.is_string());
EXPECT_EQ(result.value.GetString(), "function");
or just:
EXPECT_EQ(result.value.GetString(), "function");
Collaborator
Author
There was a problem hiding this comment.
Great catch. Fixed in 8aa596d with the second option.
iefremov
reviewed
Nov 1, 2021
| } else { | ||
| auto result = content::EvalJs(main_frame(), "self.showOpenFilePicker()"); | ||
| EXPECT_TRUE( | ||
| result.error.find("self.showOpenFilePicker is not a function") != |
iefremov
approved these changes
Nov 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#18979
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: