system/ui: fix cruise disabled state displaying "?" instead of "–"#35416
Merged
adeebshihadeh merged 1 commit intocommaai:masterfrom Jun 1, 2025
Merged
system/ui: fix cruise disabled state displaying "?" instead of "–"#35416adeebshihadeh merged 1 commit intocommaai:masterfrom
adeebshihadeh merged 1 commit intocommaai:masterfrom
Conversation
Contributor
|
this breaks the spinner on devices without anything compiled comma@comma-7e8e41ad:/data/openpilot$ git clean -xfd && rm -rf /data/scons_cache/ && ./launch_openpilot.sh
RAYLIB STATIC 5.5.0.2 LOADED
kj/filesystem-disk-unix.c++:1734: warning: PWD environment variable doesn't match current directory; pwd = /data/openpilot/system/manager
gbm_create_device(156): Info: backend name is: msm_drm
Traceback (most recent call last):
File "/data/openpilot/system/ui/./spinner.py", line 106, in <module>
main()
File "/data/openpilot/system/ui/./spinner.py", line 95, in main
gui_app.init_window("Spinner")
File "/data/openpilot/openpilot/system/ui/lib/application.py", line 89, in init_window
self._load_fonts()
File "/data/openpilot/openpilot/system/ui/lib/application.py", line 221, in _load_fonts
from openpilot.selfdrive.ui.onroad.hud_renderer import CRUISE_DISABLED_CHAR
File "/data/openpilot/openpilot/selfdrive/ui/onroad/hud_renderer.py", line 4, in <module>
from openpilot.selfdrive.ui.ui_state import ui_state, UIStatus
File "/data/openpilot/openpilot/selfdrive/ui/ui_state.py", line 4, in <module>
from openpilot.common.params import Params, UnknownKeyName
File "/data/openpilot/openpilot/common/params.py", line 1, in <module>
from openpilot.common.params_pyx import Params, ParamKeyType, UnknownKeyName
ModuleNotFoundError: No module named 'openpilot.common.params_pyx' |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before:


after: