Drop tinyxml dependency #858
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoval
approved these changes
Mar 31, 2017
Member
Author
|
The build error on macOS is because the urdfdom formula just depends on tinyxml as a build dependency. I will submit a pull request to the upstream to fix that. This PR will be pending on the change for sure. |
Member
Author
|
Pull request is created: homebrew-deps #29 |
Member
Author
|
The Homebrew formula of urdfdom is fixed as homebrew-deps #29 is merged. However, it seems |
jslee02
added
status: blocked
Closed
Member
Author
|
Let me reopen when it's ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discovered in #434,
tinyxmlis only a transitive dependency ofurdfdomand DART doesn't use it in the public API. This PR drops the explicit dependency oftinyxml.This change is