Skip to content

Conversation

@sumeet-detect
Copy link

Motivation and context

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2022 Intel Corporation
#
# SPDX-License-Identifier: MIT

bsekachev and others added 30 commits September 1, 2022 12:26
* Fixed issue: Maximum callstack exceed

* Updated version & changelog
* Added tests to create/get a task with skeletons

* Added some dummy data for tests

* Added a couple of tests

* Aborted extra changes

* Added a couple of put tests

* Removed extra lines

* Added test to check object state logic for complex objects

* Updated eslint config file

* Fixed config

* Removed extra space

* Fixed lint-staged config
* Updated config

* Added skeleton drawing

* Added first cypresst test with skeletons

* Reworked split

* Added drawing/merging/splitting

* Fixed IDs order

* Fixed case 107
Added the information about DL models adding
* Fixed redrawing a skeleton (Shift+N)

* Updated version

* Added cypress test

* Enabled disabled tests

* Updated test IDs
…bly null (cvat-ai#4932)

* fix type declaration of private fields in cvat-canvas which are possibly null

* v2.15.3
Co-authored-by: kirill-sizov <kirill.sizov@intel.com>
* add alert when uploading photo and video together

* add creating multiple tasks for My computer tabs

* add creating multiple tasks for Remote source tab

* add creating multi tasks for File share tab

* add libmagic in dockerfile

* fix lint

* change class name of create multi tasks button

* fix incorrect deletion of validation error notification

* add opportunity upload manifest.jsonl with image files for single task create

* remove status showing of task from multitasks case

* refactoring create queue in mutlitasks case

* fix warning

* revert incorrect remove notification about error

* fix showing error of clone the repository

* fix esling error

* move of initialValue creating for task name

* rename isMultiTask properti to many

* return  incorrect deleted progress value

* add source and license on icon file

* fix unhandled promise rejection

* change mime_type getter method

* add hint how to see these template rules

* refactoring of multi task progress markup

* remove unnecessary processings for share

* remove unnecessary notification

* remove opportunity upload no video on multi mode

* correct formation of the task name

* rename function

* change queueSize to 1

* fix root selecting on share tab

* refactoring selectCloudStorageFiles logic

* add debig info. temporarily

* Some fixes

* Tried to fix unstable test

* Adjusted messages

* Fixed license headers

Co-authored-by: Boris <sekachev.bs@gmail.com>
zhiltsov-max and others added 26 commits December 8, 2022 17:05
Extracted some enhancements from
cvat-ai#4819

- Extracted common s3 manipulations in tests
- Refactored import/export tests to be more clear
Added a general solution for checking bucket and file status instead of
checking in all places. Exception information has become more
user-friendly.
Extracted from cvat-ai#5083 
Related cvat-ai#5096 

- Improved dataset manifest docs
- Dataset manifest requirements are now installed in the server image
- Package dependencies are aligned with the server
- Reduced request status checks period to 2 sec.
- Fixed parameter help message
Closes cvat-ai#5327

- Added a way to debug the server in Docker-based deployments
- Added docs
Ported from cvat-ai#4819

- Fixed project APIs in SDK core
- Added tests for projects
…-ai#5442)

<!-- Raised an issue to propose your change
(https://github.com/cvat-ai/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the
[CONTRIBUTION](https://github.com/cvat-ai/cvat/blob/develop/CONTRIBUTING.md)
guide. -->

<!-- Provide a general summary of your changes in the Title above -->

### Motivation and context
<!-- Why is this change required? What problem does it solve? If it
fixes an open
issue, please link to the issue here. Describe your changes in detail,
add
screenshots. -->

### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->

### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable by a reason then ~~explicitly
strikethrough~~ the whole
line. If you don't do that github will show an incorrect process for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [ ] I have added a description of my changes into
[CHANGELOG](https://github.com/cvat-ai/cvat/blob/develop/CHANGELOG.md)
file
- [ ] I have updated the [documentation](
https://github.com/cvat-ai/cvat/blob/develop/README.md#documentation)
accordingly
- [ ] I have added tests to cover my changes
- [ ] I have linked related issues ([read github docs](

https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [x] I have increased versions of npm packages if it is necessary
([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning),

[cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning),
[cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning)
and
[cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning))

### License

- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the
project.
  Feel free to contact the maintainers if that's a concern.
…at-ai#5458)

Currently, `server.py` runs as PID 1, which means that it won't be
terminated by a `SIGTERM` signal unless it explicitly handles it (which
it doesn't). So when Docker tries to shut the container down, it sends
the server a `SIGTERM`, which gets ignored, and then sits there for 10
seconds before sending it a `SIGKILL`.

To work around this, enable the built-in Docker init program, which
forwards signals to the Python server. Since the Python server is no
longer PID 1, `SIGTERM` will now shut it down immediately.

The `init` option is supported starting from the Compose format version
3.7, so bump the version.
Fixes cvat-ai#5448, cvat-ai#5453, cvat-ai#5457

- Relaxed env var requirements in the images, no mandatory ones
- RQ workers now use a custom python class for remote debugging
- Factored out common remote debugging implementation
* Make the extractors return tensors instead of Python data structures.
* Let the user specify custom label IDs.
…vat-ai#5459)

You have to use the `import_status` action in order to query the input
status. Otherwise, the `/api/projects/{id}/dataset/` endpoint initiates
a dataset export. Currently, `import_dataset` inadvertently monitors the
status of that export, not the original import.
- Removed extra update methods from schema
- Fixed Webhooks endpoints
- Fixed Webhooks enum names

(cherry picked from commit 051f9a9)
* This patch includes the client side changes for sending email along with username, pwd in login flow
* Related backend change would be to update email without validation
Copy link
Collaborator

@ashwinr64 ashwinr64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You seem to be updating the email on db before validating the username i.e if a user tries to sign in but enters a wrong pwd, ideally you shouldn't update the email. Can you test this once?

@ashwinr64
Copy link
Collaborator

Also do create a PR only for your changes to dt-v2.3.0 branch

@ashwinr64 ashwinr64 closed this Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.